Offline intersitital - Fix sprite clipping and clipped button highlight

chrome/renderer/resources/offline.js

 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 (function() {
 'use strict';
 /**
  * T-Rex runner.
  * @param {string} outerContainerId Outer containing element id.
  * @param {object} opt_config
  * @constructor
  * @export
  */
 function Runner(outerContainerId, opt_config) {
   // Singleton
   if (Runner.instance_) {
     return Runner.instance_;
   }
   Runner.instance_ = this;
 
   this.outerContainerEl = document.querySelector(outerContainerId);
   this.containerEl = null;
+  this.detailsButton = document.querySelector('#details-button');

[arv (Not doing code reviews), 2014/09/29 16:47:42]

Should this be

this.outerContainerEl.querySelector?

[edwardjung, 2014/09/29 17:32:56]

Done.

 
   this.config = opt_config || Runner.config;
 
   this.dimensions = Runner.defaultDimensions;
 
   this.canvas = null;
   this.canvasCtx = null;
 
   this.tRex = null;
 
@@ skipping 539 matching lines @@
       document.removeEventListener(Runner.events.MOUSEDOWN, this);
       document.removeEventListener(Runner.events.MOUSEUP, this);
     }
   },
 
   /**
    * Process keydown.
    * @param {Event} e
    */
   onKeyDown: function(e) {
-    if (!this.crashed && (Runner.keycodes.JUMP[String(e.keyCode)] ||
-         e.type == Runner.events.TOUCHSTART)) {
-      if (!this.activated) {
-        this.loadSounds();
-        this.activated = true;
+    if (e.target != this.detailsButton) {
+      if (!this.crashed && (Runner.keycodes.JUMP[String(e.keyCode)] ||
+           e.type == Runner.events.TOUCHSTART)) {
+        if (!this.activated) {
+          this.loadSounds();
+          this.activated = true;
+        }
+
+        if (!this.tRex.jumping) {
+          this.playSound(this.soundFx.BUTTON_PRESS);
+          this.tRex.startJump();
+        }
       }
 
-      if (!this.tRex.jumping) {
-        this.playSound(this.soundFx.BUTTON_PRESS);
-        this.tRex.startJump();
+      if (this.crashed && e.type == Runner.events.TOUCHSTART &&
+          e.currentTarget == this.containerEl) {
+        this.restart();
       }
     }
 
-    if (this.crashed && e.type == Runner.events.TOUCHSTART &&
-        e.currentTarget == this.containerEl) {
-      this.restart();
-    }
-
     // Speed drop, activated only when jump key is not pressed.
     if (Runner.keycodes.DUCK[e.keyCode] && this.tRex.jumping) {
       e.preventDefault();
       this.tRex.setSpeedDrop();
     }
   },
 
 
   /**
    * Process key up.
@@ skipping 1239 matching lines @@
 
   this.init();
 };
 
 
 /**
  * Cloud object config.
  * @enum {number}
  */
 Cloud.config = {
-  HEIGHT: 13,
+  HEIGHT: 14,
   MAX_CLOUD_GAP: 400,
   MAX_SKY_LEVEL: 30,
   MIN_CLOUD_GAP: 100,
   MIN_SKY_LEVEL: 71,
   WIDTH: 46
 };
 
 
 Cloud.prototype = {
   /**
@@ skipping 357 matching lines @@
 
   /**
    * Add a new cloud to the horizon.
    */
   addCloud: function() {
     this.clouds.push(new Cloud(this.canvas, this.cloudImg,
         this.dimensions.WIDTH));
   }
 };
 })();