Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 609853002: Offline intersitital - Fix sprite clipping and clipped button highlight (Closed)

Created:
6 years, 2 months ago by edwardjung
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

+ Fix cloud sprite clipping on 2x + Fix clipped button highlight + Tweaked the text sprite to correct the poor font rendering. + Fix to prevent keyboard 'details' link to cause activation. BUG=418075, 417956, 418494 Committed: https://crrev.com/8602652125368621d9504ce311d075e379124d23 Cr-Commit-Position: refs/heads/master@{#297452}

Patch Set 1 #

Patch Set 2 : Fix 'details' link bug #

Total comments: 2

Patch Set 3 : Change base element for querySelector #

Patch Set 4 : Add OWNERS file to chrome/renderer/resources #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -19 lines) Patch
A chrome/renderer/resources/OWNERS View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/resources/default_100_percent/offline/100-text-sprite.png View 1 2 Binary file 0 comments Download
M chrome/renderer/resources/default_200_percent/offline/200-text-sprite.png View 1 2 Binary file 0 comments Download
M chrome/renderer/resources/neterror.css View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/renderer/resources/offline.js View 1 2 3 chunks +17 lines, -14 lines 0 comments Download

Messages

Total messages: 13 (2 generated)
edwardjung
Some small bug fix updates to the offline interstitial.
6 years, 2 months ago (2014-09-26 16:36:09 UTC) #2
arv (Not doing code reviews)
https://codereview.chromium.org/609853002/diff/20001/chrome/renderer/resources/offline.js File chrome/renderer/resources/offline.js (right): https://codereview.chromium.org/609853002/diff/20001/chrome/renderer/resources/offline.js#newcode22 chrome/renderer/resources/offline.js:22: this.detailsButton = document.querySelector('#details-button'); Should this be this.outerContainerEl.querySelector?
6 years, 2 months ago (2014-09-29 16:47:42 UTC) #3
edwardjung
Thanks again for reviewing all these offline CLs. https://codereview.chromium.org/609853002/diff/20001/chrome/renderer/resources/offline.js File chrome/renderer/resources/offline.js (right): https://codereview.chromium.org/609853002/diff/20001/chrome/renderer/resources/offline.js#newcode22 chrome/renderer/resources/offline.js:22: this.detailsButton ...
6 years, 2 months ago (2014-09-29 17:32:56 UTC) #4
arv (Not doing code reviews)
LGTM
6 years, 2 months ago (2014-09-29 17:50:25 UTC) #5
edwardjung
@sky, could I get an LGTM?
6 years, 2 months ago (2014-09-30 09:42:44 UTC) #6
sky
How about adding an OWNERS file here with arv?
6 years, 2 months ago (2014-09-30 15:47:00 UTC) #7
edwardjung
On 2014/09/30 15:47:00, sky wrote: > How about adding an OWNERS file here with arv? ...
6 years, 2 months ago (2014-09-30 16:12:43 UTC) #8
sky
LGTM
6 years, 2 months ago (2014-09-30 16:55:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/609853002/60001
6 years, 2 months ago (2014-09-30 17:20:36 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 059e248d3efb1efc2aa87408b60d0535d542898e
6 years, 2 months ago (2014-09-30 18:11:57 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 18:12:56 UTC) #13
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/8602652125368621d9504ce311d075e379124d23
Cr-Commit-Position: refs/heads/master@{#297452}

Powered by Google App Engine
This is Rietveld 408576698