Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1108)

Unified Diff: src/x64/assembler-x64.h

Issue 609843002: Refactor FrameAndConstantPoolScope and ConstantPoolUnavailableScope to be architecture independent (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Re-factoring to enable FrameAndConstantPoolScope and ConstantPoolUnavailableScope to be used by oth… Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/x64/assembler-x64.h
diff --git a/src/x64/assembler-x64.h b/src/x64/assembler-x64.h
index 568719eae473a59d82d23b94a421c63ce8c94da3..9ed3a1de81471295815e0fc844343c316a0f5fbe 100644
--- a/src/x64/assembler-x64.h
+++ b/src/x64/assembler-x64.h
@@ -1123,6 +1123,8 @@ class Assembler : public AssemblerBase {
// Generate the constant pool for the generated code.
void PopulateConstantPool(ConstantPoolArray* constant_pool);
+ bool is_constant_pool_available() const { return false; }
+
// Writes a single word of data in the code stream.
// Used for inline tables, e.g., jump-tables.
void db(uint8_t data);
@@ -1157,6 +1159,11 @@ class Assembler : public AssemblerBase {
// Jump near absolute indirect (m64)
void jmp(const Operand& src);
+ void set_constant_pool_available(bool available) {
+ // Constant pool is not supported on x64.
+ UNREACHABLE();
+ }
+
private:
byte* addr_at(int pos) { return buffer_ + pos; }
uint32_t long_at(int pos) {
@@ -1571,6 +1578,10 @@ class Assembler : public AssemblerBase {
PositionsRecorder positions_recorder_;
friend class PositionsRecorder;
+
+ // constant pool
+ friend class FrameAndConstantPoolScope;
+ friend class ConstantPoolUnavailableScope;
};

Powered by Google App Engine
This is Rietveld 408576698