Refactor FrameAndConstantPoolScope and ConstantPoolUnavailableScope to be architecture independent

src/arm64/assembler-arm64.h

Index: src/arm64/assembler-arm64.h
diff --git a/src/arm64/assembler-arm64.h b/src/arm64/assembler-arm64.h
index 9b1c5e6746df488b42e11d96febf63d772202a89..280158c54cf83178e6d5f578677067445e3420b7 100644
--- a/src/arm64/assembler-arm64.h
+++ b/src/arm64/assembler-arm64.h
@@ -1895,6 +1895,12 @@ class Assembler : public AssemblerBase {
   // Generate the constant pool for the generated code.
   void PopulateConstantPool(ConstantPoolArray* constant_pool);
 
+  bool is_constant_pool_available() const {
+    // Constant pool is not supported on arm64.
+    UNREACHABLE();
+    return false;
+  }
+

[rmcilroy, 2014/10/02 15:01:37]

I think we should put both  is_constant_pool_available() and
set_constant_pool_available(bool available) in BaseAssembler instead rather than
copying to all architectures. Could you rename to is_ool_constant_pool_available
/ set_ool_constant_pool_available to be clear then make the code:

 bool is_ool_constant_pool_available() const {
   if (FLAG_enable_ool_constant_pool) {
     return ool_constant_pool_available_;
   } else {
     // Out-of-line constant pool not supported on this architecture.
     UNREACHABLE();
     return false;
   }
 }

and similar for set_constant_pool_available.

[baixo, 2014/10/09 09:08:14]

Done.

   // Returns true if we should emit a veneer as soon as possible for a branch
   // which can at most reach to specified pc.
   bool ShouldEmitVeneer(int max_reachable_pc,
@@ -2012,6 +2018,12 @@ class Assembler : public AssemblerBase {
                                       Label* label,
                                       Instruction* label_veneer = NULL);
 
+  void set_constant_pool_available(bool available) {
+    // Constant pool is not supported on arm64.
+    UNREACHABLE();
+  }
+
+

[rmcilroy, 2014/10/02 15:01:37]

nit - remove extra newline.

[baixo, 2014/10/09 09:08:14]

Done.

  private:
   // Instruction helpers.
   void MoveWide(const Register& rd,
@@ -2248,6 +2260,10 @@ class Assembler : public AssemblerBase {
   friend class PositionsRecorder;
   friend class EnsureSpace;
   friend class ConstPool;
+
+  // constant pool

[rmcilroy, 2014/10/02 15:01:37]

These should move to BaseAssembler if you
is_constant_pool_available/set_constant_pool_available there as in my comment
above.

[baixo, 2014/10/09 09:08:14]

Done.

+  friend class FrameAndConstantPoolScope;
+  friend class ConstantPoolUnavailableScope;
 };
 
 class PatchingAssembler : public Assembler {