pkg/csslib: fixed analysis error, more cleanup

pkg/csslib/lib/src/tree_printer.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of csslib.visitor;
 
 // TODO(terry): Enable class for debug only; when conditional imports enabled.
 
 /** Helper function to dump the CSS AST. */
 String treeToDebugString(StyleSheet styleSheet, [bool useSpan = false]) {
@@ skipping 111 matching lines @@
     super.visitKeyFrameBlock(node);
     output.depth--;
   }
 
   void visitFontFaceDirective(FontFaceDirective node) {
     // TODO(terry): To Be Implemented
   }
 
   void visitStyletDirective(StyletDirective node) {
     heading('StyletDirective', node);
-    output.writeValue('dartClassName', node._dartClassName);
+    output.writeValue('dartClassName', node.dartClassName);
     output.depth++;
-    output.writeNodeList('rulesets', node._rulesets);
+    output.writeNodeList('rulesets', node.rulesets);
     output.depth--;
   }
 
   void visitNamespaceDirective(NamespaceDirective node) {
     heading('NamespaceDirective', node);
     output.depth++;
     output.writeValue('prefix', node._prefix);
     output.writeValue('uri', node._uri);
     output.depth--;
   }
@@ skipping 20 matching lines @@
     visitDeclarationGroup(node.declarations);
     output.depth--;
   }
 
   /**
    * Added optional newLine for handling @include at top-level vs/ inside of
    * a declaration group.
    */
   void visitIncludeDirective(IncludeDirective node) {
     heading('IncludeDirective ${node.name}', node);
-    output.writeNodeList('parameters', node.args);
+    var flattened = node.args.expand((e) => e).toList();

[terry, 2013/11/07 18:17:05]

Leave writeNodeList and writeList to take a List much simpler usage then having
to remember to flatten, etc.

[kevmoo-old, 2013/11/07 18:23:19]

writeNodeList assumes each element in list hase a 'visit' method, no?

I don't see other uses of writeList, so I'm removing it

+    output.writeNodeList('parameters', flattened);
   }
 
   void visitIncludeMixinAtDeclaration(IncludeMixinAtDeclaration node) {
     heading('IncludeMixinAtDeclaration ${node.include.name}', node);
     output.depth++;
     visitIncludeDirective(node.include);
     output.depth--;
   }
 
   void visitExtendDeclaration(ExtendDeclaration node) {
     heading('ExtendDeclaration', node);
     output.depth++;
     _visitNodeList(node.selectors);
     output.depth--;
   }
 
   void visitRuleSet(RuleSet node) {
     heading('Ruleset', node);
     output.depth++;
     super.visitRuleSet(node);
     output.depth--;
   }
 
   void visitDeclarationGroup(DeclarationGroup node) {
     heading('DeclarationGroup', node);
     output.depth++;
-    output.writeNodeList('declarations', node._declarations);
+    output.writeNodeList('declarations', node.declarations);
     output.depth--;
   }
 
   void visitMarginGroup(MarginGroup node) {
     heading('MarginGroup', node);
     output.depth++;
     output.writeValue('@directive', node.margin_sym);
-    output.writeNodeList('declarations', node._declarations);
+    output.writeNodeList('declarations', node.declarations);
     output.depth--;
   }
 
   void visitDeclaration(Declaration node) {
     heading('Declaration', node);
     output.depth++;
     if (node.isIE7) output.write('IE7 property');
     output.write('property');
     super.visitDeclaration(node);
     output.writeNode('expression', node._expression);
@@ skipping 327 matching lines @@
   }
 
   void visitPaddingExpression(PaddingExpression node) {
     heading('Dart Style PaddingExpression', node);
   }
 
   void visitWidthExpression(WidthExpression node) {
     heading('Dart Style WidthExpression', node);
   }
 }