pkg/csslib: fixed analysis error, more cleanup

pkg/csslib/lib/src/css_printer.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of csslib.visitor;
 
 /**
  * Visitor that produces a formatted string representation of the CSS tree.
  */
 class CssPrinter extends Visitor {
@@ skipping 86 matching lines @@
   void visitPageDirective(PageDirective node) {
     emit('$_newLine@page');
     if (node.hasIdent || node.hasPseudoPage) {
       if (node.hasIdent) emit(' ');
       emit(node._ident);
       emit(node.hasPseudoPage ? ':${node._pseudoPage}' : '');
     }
     emit(' ');
 
     var declsMargin = node._declsMargin;
     int declsMarginLength = declsMargin.length;

[terry, 2013/11/20 14:07:25]

var

     for (var i = 0; i < declsMarginLength; i++) {
       if (i > 0) emit(_newLine);
       emit('{$_newLine');
       declsMargin[i].visit(this);
       emit('}');
     }
   }
 
   /** @charset "charset encoding" */
   void visitCharsetDirective(CharsetDirective node) {
     emit('$_newLine@charset "${node.charEncoding}";');
   }
 
   void visitImportDirective(ImportDirective node) {
     bool isStartingQuote(String ch) => ('\'"'.indexOf(ch[0]) >= 0);

[terry, 2013/11/20 14:07:25]

var

 
     if (_isTesting) {
       // Emit assuming url() was parsed; most suite tests use url function.
       emit(' @import url(${node.import})');
     } else if (isStartingQuote(node.import)) {
       emit(' @import ${node.import}');
     } else {
       // url(...) isn't needed only a URI can follow an @import directive; emit
       // url as a string.
       emit(' @import "${node.import}"');
@@ skipping 21 matching lines @@
 
   void visitKeyFrameBlock(KeyFrameBlock node) {
     emit('$_sp$_sp');
     node._blockSelectors.visit(this);
     emit('$_sp{$_newLine');
     node._declarations.visit(this);
     emit('$_sp$_sp}$_newLine');
   }
 
   void visitStyletDirective(StyletDirective node) {
-    emit('/* @stylet export as ${node._dartClassName} */\n');
+    emit('/* @stylet export as ${node.dartClassName} */\n');
   }
 
   void visitNamespaceDirective(NamespaceDirective node) {
     bool isStartingQuote(String ch) => ('\'"'.indexOf(ch) >= 0);

[terry, 2013/11/20 14:07:25]

var

[terry, 2013/11/20 16:45:08]

ignore.
On 2013/11/20 14:07:25, terry wrote:

 
     if (isStartingQuote(node._uri)) {
       emit(' @namespace ${node.prefix}"${node._uri}"');
     } else {
       if (_isTesting) {
         // Emit exactly was we parsed.
         emit(' @namespace ${node.prefix}url(${node._uri})');
       } else {
         // url(...) isn't needed only a URI can follow a:
         //    @namespace prefix directive.
@@ skipping 38 matching lines @@
 
   void visitRuleSet(RuleSet node) {
     emit("$_newLine");
     node._selectorGroup.visit(this);
     emit(" {$_newLine");
     node._declarationGroup.visit(this);
     emit("}");
   }
 
   void visitDeclarationGroup(DeclarationGroup node) {
-    var declarations = node._declarations;
+    var declarations = node.declarations;
     var declarationsLength = declarations.length;
     for (var i = 0; i < declarationsLength; i++) {
       if (i > 0) emit(_newLine);
       emit("$_sp$_sp");
       declarations[i].visit(this);
       emit(";");
     }
     if (declarationsLength > 0) emit(_newLine);
   }
 
   void visitMarginGroup(MarginGroup node) {
     var margin_sym_name =
         TokenKind.idToValue(TokenKind.MARGIN_DIRECTIVES, node.margin_sym);
 
     emit("@$margin_sym_name {$_newLine");
 
     visitDeclarationGroup(node);
 
     emit("}$_newLine");
   }
 
   void visitDeclaration(Declaration node) {
     String importantAsString() => node.important ? '$_sp!important' : '';

[terry, 2013/11/20 14:07:25]

var

[terry, 2013/11/20 16:45:08]

ignore
On 2013/11/20 14:07:25, terry wrote:

 
     emit("${node.property}: ");
     node._expression.visit(this);
 
     emit("${importantAsString()}");
   }
 
   void visitVarDefinition(VarDefinition node) {
     emit("var-${node.definedName}: ");
     node._expression.visit(this);
@@ skipping 70 matching lines @@
     emit(')');
   }
 
   void visitNegationSelector(NegationSelector node) {
     emit(':not(');
     node.negationArg.visit(this);
     emit(')');
   }
 
   void visitSelectorExpression(SelectorExpression node) {
-    var expressions = node._expressions;
+    var expressions = node.expressions;
     var expressionsLength = expressions.length;
     for (var i = 0; i < expressionsLength; i++) {
       // Add space seperator between terms without an operator.
       var expression = expressions[i];
       expression.visit(this);
     }
   }
 
   void visitUnicodeRangeTerm(UnicodeRangeTerm node) {
     if (node.hasSecond) {
@@ skipping 156 matching lines @@
 
   void visitWildcard(Wildcard node) {
     emit('*');
   }
 
   void visitDartStyleExpression(DartStyleExpression node) {
     // TODO(terry): TBD
     throw UnimplementedError;
   }
 }