Improve SkARGB32_A8_BlitMask_SSE2

Improve SkARGB32_A8_BlitMask_SSE2

With clang this:

-       movzbl  -3(%rbx), %edx
-       pxor    %xmm5, %xmm5
-       pinsrw  $0, %edx, %xmm5
-       pinsrw  $1, %edx, %xmm5
-       movzbl  -2(%rbx), %edx
-       pinsrw  $2, %edx, %xmm5
-       pinsrw  $3, %edx, %xmm5
-       movzbl  -1(%rbx), %edx
-       pinsrw  $4, %edx, %xmm5
-       pinsrw  $5, %edx, %xmm5
-       movzbl  (%rbx), %edx
-       pinsrw  $6, %edx, %xmm5
-       pinsrw  $7, %edx, %xmm5

becomes:

+       movd    (%rbx), %xmm4
+       punpcklbw       %xmm9, %xmm4
+       punpcklwd       %xmm4, %xmm4

And clang already does better codegen than msvc 2013 on this.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/60e4ad7b29f50ebd7698d2d37580d5c8da5ce600

[jmuizelaar, 2014-09-29 19:07:30]

jmuizelaar@mozilla.com changed reviewers:
+ reed@google.com

[jmuizelaar, 2014-10-03 19:05:07]

With clang this: 

- movzbl -3(%rbx), %edx 
- pxor %xmm5, %xmm5 
- pinsrw $0, %edx, %xmm5 
- pinsrw $1, %edx, %xmm5 
- movzbl -2(%rbx), %edx 
- pinsrw $2, %edx, %xmm5 
- pinsrw $3, %edx, %xmm5 
- movzbl -1(%rbx), %edx 
- pinsrw $4, %edx, %xmm5 
- pinsrw $5, %edx, %xmm5 
- movzbl (%rbx), %edx 
- pinsrw $6, %edx, %xmm5 
- pinsrw $7, %edx, %xmm5

 becomes: 
+ movd (%rbx), %xmm4 
+ punpcklbw %xmm9, %xmm4 
+ punpcklwd %xmm4, %xmm4

And clang already does better codegen than msvc 2013 on this.

[mtklein, 2014-10-03 19:49:49]

mtklein@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2014-10-03 19:49:50]

lgtm

https://codereview.chromium.org/609823003/diff/1/src/opts/SkBlitRow_opts_SSE2...
File src/opts/SkBlitRow_opts_SSE2.cpp (right):

https://codereview.chromium.org/609823003/diff/1/src/opts/SkBlitRow_opts_SSE2...
src/opts/SkBlitRow_opts_SSE2.cpp:444: __m128i src_scale_wide =
_mm_cvtsi32_si128(*reinterpret_cast<const uint32_t*>(mask));
Please replace tabs with spaces before landing this.

[jmuizelaar, 2014-10-09 18:32:00]

The CQ bit was checked by jmuizelaar@mozilla.com

[commit-bot: I haz the power, 2014-10-09 18:32:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/609823003/20001

[commit-bot: I haz the power, 2014-10-09 18:32:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-09 18:32:27]

Presubmit check for 609823003-20001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
The email jmuizelaar@mozilla.com is not in Skia's AUTHORS file.
Issue owner, this CL must include an addition to the Skia AUTHORS file.
Googler reviewers, please check that the AUTHORS entry corresponds to an email
address in http://goto/cla-signers. If it does not then ask the issue owner to
sign the CLA at https://developers.google.com/open-source/cla/individual
(individual) or https://developers.google.com/open-source/cla/corporate
(corporate).

[jmuizelaar, 2014-10-09 18:34:41]

The CQ bit was checked by jmuizelaar@mozilla.com

[commit-bot: I haz the power, 2014-10-09 18:35:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/609823003/80001

[commit-bot: I haz the power, 2014-10-09 18:43:08]

Committed patchset #3 (id:80001) as 60e4ad7b29f50ebd7698d2d37580d5c8da5ce600

[hcm, 2014-10-09 18:47:27]

On 2014/10/09 18:32:27, I haz the power (commit-bot) wrote:
> Presubmit check for 609823003-20001 failed and returned exit status 1.
> 
> Running presubmit commit checks ...
> 
> ** Presubmit ERRORS **
> The email mailto:jmuizelaar@mozilla.com is not in Skia's AUTHORS file.
> Issue owner, this CL must include an addition to the Skia AUTHORS file.
> Googler reviewers, please check that the AUTHORS entry corresponds to an email
> address in http://goto/cla-signers. If it does not then ask the issue owner to
> sign the CLA at https://developers.google.com/open-source/cla/individual
> (individual) or https://developers.google.com/open-source/cla/corporate
> (corporate).

Just sent email to Jeff and George- we need to get Mozilla to sign a corporate
CLA form and then add *@mozilla.com to the AUTHORS file so the rest of their
team can commit without a problem.

[jmuizelaar, 2014-10-09 18:56:14]

On 2014/10/09 18:47:27, hcm wrote:
> On 2014/10/09 18:32:27, I haz the power (commit-bot) wrote:
> > Presubmit check for 609823003-20001 failed and returned exit status 1.
> > 
> > Running presubmit commit checks ...
> > 
> > ** Presubmit ERRORS **
> > The email mailto:jmuizelaar@mozilla.com is not in Skia's AUTHORS file.
> > Issue owner, this CL must include an addition to the Skia AUTHORS file.
> > Googler reviewers, please check that the AUTHORS entry corresponds to an
email
> > address in http://goto/cla-signers. If it does not then ask the issue owner
to
> > sign the CLA at https://developers.google.com/open-source/cla/individual
> > (individual) or https://developers.google.com/open-source/cla/corporate
> > (corporate).
> 
> Just sent email to Jeff and George- we need to get Mozilla to sign a corporate
> CLA form and then add mailto:*@mozilla.com to the AUTHORS file so the rest of
their
> team can commit without a problem.

I believe Mozilla should already have a corporate CLA form with Google.
Especially if the same CLA can be shared among multiple Google projects. (We
should have one for the VP8/VP9 project)