Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 609813003: Remove broken szdiff tests. (Closed)

Created:
6 years, 2 months ago by Karl
Modified:
6 years, 2 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Remove broken szdiff tests. szdiff is an approximate match tool used in early tests. When Subzero's bitcode reader tests already exist for failing cases of szdiff, remove the broken tests. BUG=None R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=5081c21bb4ab83a936e6806150352a4c1c57093a

Patch Set 1 #

Patch Set 2 : Fix nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -61 lines) Patch
M tests_lit/llvm2ice_tests/64bit.pnacl.ll View 1 2 chunks +0 lines, -3 lines 0 comments Download
M tests_lit/llvm2ice_tests/alloc.ll View 1 2 chunks +0 lines, -3 lines 0 comments Download
M tests_lit/llvm2ice_tests/callindirect.pnacl.ll View 2 chunks +0 lines, -3 lines 0 comments Download
M tests_lit/llvm2ice_tests/convert.ll View 1 2 chunks +0 lines, -3 lines 0 comments Download
M tests_lit/llvm2ice_tests/fp.pnacl.ll View 2 chunks +0 lines, -3 lines 0 comments Download
M tests_lit/llvm2ice_tests/global.ll View 2 chunks +0 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/globalinit.pnacl.ll View 2 chunks +0 lines, -3 lines 0 comments Download
M tests_lit/llvm2ice_tests/load.ll View 5 chunks +9 lines, -12 lines 0 comments Download
M tests_lit/llvm2ice_tests/nacl-atomic-cmpxchg-optimization.ll View 2 chunks +0 lines, -3 lines 0 comments Download
M tests_lit/llvm2ice_tests/nacl-atomic-intrinsics.ll View 2 chunks +0 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/nacl-other-intrinsics.ll View 2 chunks +0 lines, -3 lines 0 comments Download
M tests_lit/llvm2ice_tests/shift.ll View 2 chunks +0 lines, -3 lines 0 comments Download
M tests_lit/llvm2ice_tests/simple-loop.ll View 2 chunks +0 lines, -3 lines 0 comments Download
M tests_lit/llvm2ice_tests/store.ll View 5 chunks +10 lines, -13 lines 0 comments Download
M tests_lit/llvm2ice_tests/struct-arith.pnacl.ll View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Karl
6 years, 2 months ago (2014-09-26 15:50:45 UTC) #2
Jim Stichnoth
LGTM. For the record, I'm in favor of phasing out szdiff entirely. Its original purpose ...
6 years, 2 months ago (2014-09-26 16:04:10 UTC) #3
Karl
6 years, 2 months ago (2014-09-26 16:17:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 5081c21 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698