Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1302)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 609813002: Use LocalStyleChange for content:attr() changes. (Closed)

Created:
6 years, 2 months ago by rune
Modified:
6 years, 2 months ago
Reviewers:
chrishtr, esprehn
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis, rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Use LocalStyleChange for content:attr() changes. LocalStyleChange should be sufficient for updating pseudo elements when attributes affecting the content property changes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182830

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added invalidation tests #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -2 lines) Patch
A LayoutTests/fast/css-generated-content/attr-content-dynamic.html View 1 chunk +13 lines, -0 lines 1 comment Download
A LayoutTests/fast/css-generated-content/attr-content-dynamic-expected.html View 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/invalidation/content-attr.html View 1 1 chunk +41 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/invalidation/content-attr-expected.txt View 1 1 chunk +12 lines, -0 lines 0 comments Download
M Source/core/css/RuleFeature.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
rune
6 years, 2 months ago (2014-09-26 13:55:44 UTC) #2
chrishtr
https://codereview.chromium.org/609813002/diff/1/LayoutTests/fast/css-generated-content/attr-content-dynamic.html File LayoutTests/fast/css-generated-content/attr-content-dynamic.html (right): https://codereview.chromium.org/609813002/diff/1/LayoutTests/fast/css-generated-content/attr-content-dynamic.html#newcode12 LayoutTests/fast/css-generated-content/attr-content-dynamic.html:12: after.setAttribute("my-value", "SS"); Please make an example that has a ...
6 years, 2 months ago (2014-09-26 17:31:56 UTC) #3
rune
https://codereview.chromium.org/609813002/diff/1/LayoutTests/fast/css-generated-content/attr-content-dynamic.html File LayoutTests/fast/css-generated-content/attr-content-dynamic.html (right): https://codereview.chromium.org/609813002/diff/1/LayoutTests/fast/css-generated-content/attr-content-dynamic.html#newcode12 LayoutTests/fast/css-generated-content/attr-content-dynamic.html:12: after.setAttribute("my-value", "SS"); On 2014/09/26 at 17:31:56, chrishtr wrote: > ...
6 years, 2 months ago (2014-09-27 13:10:35 UTC) #4
esprehn
lgtm https://codereview.chromium.org/609813002/diff/20001/LayoutTests/fast/css-generated-content/attr-content-dynamic.html File LayoutTests/fast/css-generated-content/attr-content-dynamic.html (right): https://codereview.chromium.org/609813002/diff/20001/LayoutTests/fast/css-generated-content/attr-content-dynamic.html#newcode12 LayoutTests/fast/css-generated-content/attr-content-dynamic.html:12: after.setAttribute("my-value", "SS"); This is really cute.
6 years, 2 months ago (2014-09-29 03:47:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/609813002/20001
6 years, 2 months ago (2014-09-29 06:41:34 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 10:00:48 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 182830

Powered by Google App Engine
This is Rietveld 408576698