Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: Source/core/html/DOMFormData.cpp

Issue 609733004: FormData allow empty names to append (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added issue title in description Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/http/tests/local/formdata/send-form-data-with-empty-name-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 51
52 for (unsigned i = 0; i < form->associatedElements().size(); ++i) { 52 for (unsigned i = 0; i < form->associatedElements().size(); ++i) {
53 FormAssociatedElement* element = form->associatedElements()[i]; 53 FormAssociatedElement* element = form->associatedElements()[i];
54 if (!toHTMLElement(element)->isDisabledFormControl()) 54 if (!toHTMLElement(element)->isDisabledFormControl())
55 element->appendFormData(*this, true); 55 element->appendFormData(*this, true);
56 } 56 }
57 } 57 }
58 58
59 void DOMFormData::append(const String& name, const String& value) 59 void DOMFormData::append(const String& name, const String& value)
60 { 60 {
61 if (!name.isEmpty()) 61 appendData(name, value);
62 appendData(name, value);
63 } 62 }
64 63
65 void DOMFormData::append(const String& name, Blob* blob, const String& filename) 64 void DOMFormData::append(const String& name, Blob* blob, const String& filename)
66 { 65 {
67 if (!name.isEmpty()) 66 appendBlob(name, blob, filename);
68 appendBlob(name, blob, filename);
69 } 67 }
70 68
71 } // namespace blink 69 } // namespace blink
OLDNEW
« no previous file with comments | « LayoutTests/http/tests/local/formdata/send-form-data-with-empty-name-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698