cc/quads/render_pass_unittest.cc - Issue 609663003: cc: Remove use of PassAs() and constructor-casting with scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/quads/render_pass_unittest.cc

Issue 609663003: cc: Remove use of PassAs() and constructor-casting with scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: cc-passas: PassAs-presubmit-warning Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/quads/render_pass_unittest.cc

diff --git a/cc/quads/render_pass_unittest.cc b/cc/quads/render_pass_unittest.cc

index 3ddf2692adc55d23e9604b331a0359e99b4c5e6f..36e57d0a37487f8ec10549238536dbfa16de1b2a 100644

--- a/cc/quads/render_pass_unittest.cc

+++ b/cc/quads/render_pass_unittest.cc

@@ -225,8 +225,8 @@ TEST(RenderPassTest, CopyAllShouldBeIdentical) {

gfx::Vector2dF(), // filters_scale

FilterOperations());

- pass_list.push_back(pass.PassAs<RenderPass>());

- pass_list.push_back(contrib.PassAs<RenderPass>());

+ pass_list.push_back(pass.Pass());

+ pass_list.push_back(contrib.Pass());

// Make a copy with CopyAll().

RenderPassList copy_list;

@@ -310,7 +310,7 @@ TEST(RenderPassTest, CopyAllWithCulledQuads) {

gfx::Rect(3, 3, 3, 3),

SkColor());

- pass_list.push_back(pass.PassAs<RenderPass>());

+ pass_list.push_back(pass.Pass());

// Make a copy with CopyAll().

RenderPassList copy_list;

« no previous file with comments | « cc/quads/draw_polygon.cc ('k') | cc/resources/bitmap_content_layer_updater.cc » ('j') | no next file with comments »