Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Side by Side Diff: cc/layers/video_layer.cc

Issue 609663003: cc: Remove use of PassAs() and constructor-casting with scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cc-passas: PassAs-presubmit-warning Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/layers/ui_resource_layer_impl.cc ('k') | cc/layers/video_layer_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 The Chromium Authors. All rights reserved. 1 // Copyright 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/layers/video_layer.h" 5 #include "cc/layers/video_layer.h"
6 6
7 #include "cc/layers/video_layer_impl.h" 7 #include "cc/layers/video_layer_impl.h"
8 8
9 namespace cc { 9 namespace cc {
10 10
11 scoped_refptr<VideoLayer> VideoLayer::Create( 11 scoped_refptr<VideoLayer> VideoLayer::Create(
12 VideoFrameProvider* provider, 12 VideoFrameProvider* provider,
13 media::VideoRotation video_rotation) { 13 media::VideoRotation video_rotation) {
14 return make_scoped_refptr(new VideoLayer(provider, video_rotation)); 14 return make_scoped_refptr(new VideoLayer(provider, video_rotation));
15 } 15 }
16 16
17 VideoLayer::VideoLayer(VideoFrameProvider* provider, 17 VideoLayer::VideoLayer(VideoFrameProvider* provider,
18 media::VideoRotation video_rotation) 18 media::VideoRotation video_rotation)
19 : provider_(provider), video_rotation_(video_rotation) { 19 : provider_(provider), video_rotation_(video_rotation) {
20 DCHECK(provider_); 20 DCHECK(provider_);
21 } 21 }
22 22
23 VideoLayer::~VideoLayer() {} 23 VideoLayer::~VideoLayer() {}
24 24
25 scoped_ptr<LayerImpl> VideoLayer::CreateLayerImpl(LayerTreeImpl* tree_impl) { 25 scoped_ptr<LayerImpl> VideoLayer::CreateLayerImpl(LayerTreeImpl* tree_impl) {
26 scoped_ptr<VideoLayerImpl> impl = 26 scoped_ptr<VideoLayerImpl> impl =
27 VideoLayerImpl::Create(tree_impl, id(), provider_, video_rotation_); 27 VideoLayerImpl::Create(tree_impl, id(), provider_, video_rotation_);
28 return impl.PassAs<LayerImpl>(); 28 return impl.Pass();
29 } 29 }
30 30
31 bool VideoLayer::Update(ResourceUpdateQueue* queue, 31 bool VideoLayer::Update(ResourceUpdateQueue* queue,
32 const OcclusionTracker<Layer>* occlusion) { 32 const OcclusionTracker<Layer>* occlusion) {
33 bool updated = Layer::Update(queue, occlusion); 33 bool updated = Layer::Update(queue, occlusion);
34 34
35 // Video layer doesn't update any resources from the main thread side, 35 // Video layer doesn't update any resources from the main thread side,
36 // but repaint rects need to be sent to the VideoLayerImpl via commit. 36 // but repaint rects need to be sent to the VideoLayerImpl via commit.
37 // 37 //
38 // This is the inefficient legacy redraw path for videos. It's better to 38 // This is the inefficient legacy redraw path for videos. It's better to
39 // communicate this directly to the VideoLayerImpl. 39 // communicate this directly to the VideoLayerImpl.
40 updated |= !update_rect_.IsEmpty(); 40 updated |= !update_rect_.IsEmpty();
41 41
42 return updated; 42 return updated;
43 } 43 }
44 44
45 } // namespace cc 45 } // namespace cc
OLDNEW
« no previous file with comments | « cc/layers/ui_resource_layer_impl.cc ('k') | cc/layers/video_layer_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698