Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 609593002: - Remove Isolate::CurrentAddress(). (Closed)

Created:
6 years, 2 months ago by Ivan Posva
Modified:
6 years, 2 months ago
Reviewers:
rmacnak, srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Florian Schneider
Visibility:
Public.

Description

- Remove Isolate::CurrentAddress(). - Remove use of INFINITY and -INFINITY. R=rmacnak@google.com, srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=40700

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -56 lines) Patch
M runtime/bin/crypto_macos.cc View 1 chunk +3 lines, -1 line 0 comments Download
M runtime/platform/c99_support_win.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/assembler_arm.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/assembler_arm.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/assembler_arm64.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/assembler_arm64.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/assembler_arm64_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/assembler_arm_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/assembler_ia32.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/assembler_ia32.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/assembler_mips.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/assembler_mips.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/assembler_x64.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/assembler_x64.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/globals.h View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/isolate.h View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/simulator_arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/simulator_arm64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/stub_code_arm.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M runtime/vm/stub_code_arm64.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M runtime/vm/stub_code_mips.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 7 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Ivan Posva
6 years, 2 months ago (2014-09-25 23:14:13 UTC) #2
srdjan
lgtm
6 years, 2 months ago (2014-09-25 23:19:56 UTC) #3
rmacnak
LGTM
6 years, 2 months ago (2014-09-25 23:24:11 UTC) #4
Ivan Posva
6 years, 2 months ago (2014-09-25 23:39:44 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as r40700 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698