runtime/vm/object_set.h - Issue 609563002: Address MSVS 2013 warning C4146: unary minus operator applied to unsigned type, result still unsign…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object_set.h

Issue 609563002: Address MSVS 2013 warning C4146: unary minus operator applied to unsigned type, result still unsign… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/object_set.h

diff --git a/runtime/vm/object_set.h b/runtime/vm/object_set.h

index 6f687a9663af987907ae5376147e8e83dffbf09f..58b5b9b3e273abb741cff2e07ddfe36470440478 100644

--- a/runtime/vm/object_set.h

+++ b/runtime/vm/object_set.h

@@ -31,7 +31,8 @@ class ObjectSet {

ASSERT(start_ <= end_);

size_ = SizeFor((end_ - start_) >> kWordSizeLog2);

allocation_ = new uword[size_];

- data_ = &allocation_[-((start >> kWordSizeLog2) / kBitsPerWord)];

+ intptr_t skipped_bitfield_words = ((start >> kWordSizeLog2) / kBitsPerWord);

+ data_ = &allocation_[-skipped_bitfield_words];

ASSERT(allocation_ == &data_[(start >> kWordSizeLog2) / kBitsPerWord]);

koda 2014/09/25 22:08:23 Please make it a "const intptr_t" and then use it

rmacnak 2014/09/25 22:15:23 Done.

Clear();

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »