Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Side by Side Diff: chrome/common/instant_types_unittest.cc

Issue 609493002: Propagate the search request params from the browser to the Instant search base page to fix the embe (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/common/instant_types.cc ('k') | chrome/common/render_messages.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/common/instant_types.h"
6
7 #include "base/strings/utf_string_conversions.h"
8 #include "testing/gtest/include/gtest/gtest.h"
9
10 struct TestData {
11 const char* search_request_url;
12 const char* expected_search_query;
13 const char* expected_original_query;
14 const char* expected_rlz_param;
15 const char* expected_input_encoding;
16 const char* expected_assisted_query_stats;
17 };
18
19 TEST(EmbeddedSearchRequestParams, ExtractParams) {
20 TestData cases[] = {
21 {"https://foo/search?q=google&oq=g&rlz=30ls&ie=utf-8&aqs=chrome..6l5.j04",
22 "google",
23 "g",
24 "30ls",
25 "utf-8",
26 "chrome..6l5.j04"
27 },
28 // Do not populate "rlz" param.
29 {"https://foo/search?q=google%20j&oq=g&ie=utf-8&aqs=chrome.2.65.j04",
30 "google j",
31 "g",
32 "",
33 "utf-8",
34 "chrome.2.65.j04"
35 },
36 // Unescape search query.
37 {"https://foo/search?q=google+j&oq=g&rlz=30&ie=utf-8&aqs=chrome.2.65.j04",
38 "google j",
39 "g",
40 "30",
41 "utf-8",
42 "chrome.2.65.j04"
43 },
44 // Unescape original query.
45 {"https://foo/search?q=g+j%20j&oq=g+j&rlz=30&ie=utf-8&aqs=chrome.2.65.j04",
46 "g j j",
47 "g j",
48 "30",
49 "utf-8",
50 "chrome.2.65.j04"
51 },
52 };
53
54 for (size_t i = 0; i < arraysize(cases); ++i) {
55 EmbeddedSearchRequestParams params(GURL(cases[i].search_request_url));
56 EXPECT_EQ(cases[i].expected_search_query,
57 base::UTF16ToASCII(params.search_query)) << "For index: " << i;
58 EXPECT_EQ(cases[i].expected_original_query,
59 base::UTF16ToASCII(params.original_query)) << "For index: " << i;
60 EXPECT_EQ(cases[i].expected_rlz_param,
61 base::UTF16ToASCII(params.rlz_parameter_value)) <<
62 "For index: " << i;
63 EXPECT_EQ(cases[i].expected_input_encoding,
64 base::UTF16ToASCII(params.input_encoding)) << "For index: " << i;
65 EXPECT_EQ(cases[i].expected_assisted_query_stats,
66 base::UTF16ToASCII(params.assisted_query_stats)) <<
67 "For index: " << i;
68 }
69 }
OLDNEW
« no previous file with comments | « chrome/common/instant_types.cc ('k') | chrome/common/render_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698