Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: chrome/common/instant_types.h

Issue 609493002: Propagate the search request params from the browser to the Instant search base page to fix the embe (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: '' Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_COMMON_INSTANT_TYPES_H_ 5 #ifndef CHROME_COMMON_INSTANT_TYPES_H_
6 #define CHROME_COMMON_INSTANT_TYPES_H_ 6 #define CHROME_COMMON_INSTANT_TYPES_H_
7 7
8 #include <string> 8 #include <string>
9 #include <utility> 9 #include <utility>
10 10
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
124 124
125 // The title of the Most Visited page. May be empty, in which case the |url| 125 // The title of the Most Visited page. May be empty, in which case the |url|
126 // is used as the title. 126 // is used as the title.
127 base::string16 title; 127 base::string16 title;
128 }; 128 };
129 129
130 // An InstantMostVisitedItem along with its assigned restricted ID. 130 // An InstantMostVisitedItem along with its assigned restricted ID.
131 typedef std::pair<InstantRestrictedID, InstantMostVisitedItem> 131 typedef std::pair<InstantRestrictedID, InstantMostVisitedItem>
132 InstantMostVisitedItemIDPair; 132 InstantMostVisitedItemIDPair;
133 133
134 // Embedded search request logging stats params.
samarth 2014/11/14 08:09:31 Do these really need to be in the header?
kmadhusu 2014/11/14 18:54:58 Yes. I use them in searchbox_extension.cc.
135 extern const char kSearchQueryKey[];
136 extern const char kOriginalQueryKey[];
137 extern const char kRLZParameterKey[];
138 extern const char kInputEncodingKey[];
139 extern const char kAssistedQueryStatsKey[];
140
141 // A wrapper to hold embedded search request params. Used to tell the server
142 // about the search query logging stats at the query submission time.
143 struct EmbeddedSearchRequestParams {
144 EmbeddedSearchRequestParams();
145 // Extracts the request params from the |url| and initializes the member
146 // variables.
147 explicit EmbeddedSearchRequestParams(const GURL& url);
148 ~EmbeddedSearchRequestParams();
149
150 // Submitted search query.
151 base::string16 search_query;
152
153 // User typed query.
154 base::string16 original_query;
155
156 // RLZ parameter.
157 base::string16 rlz_parameter_value;
158
159 // Character input encoding type.
160 base::string16 input_encoding;
161
162 // The optional assisted query stats, aka AQS, used for logging purposes.
163 // This string contains impressions of all autocomplete matches shown
164 // at the query submission time. For privacy reasons, we require the
165 // search provider to support HTTPS protocol in order to receive the AQS
166 // param.
167 // For more details, see http://goto.google.com/binary-clients-logging.
168 base::string16 assisted_query_stats;
169 };
134 #endif // CHROME_COMMON_INSTANT_TYPES_H_ 170 #endif // CHROME_COMMON_INSTANT_TYPES_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698