Propagate the search request params from the browser to the Instant search base page to fix the embe

chrome/common/instant_types.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/instant_types.h"
 
+#include "base/strings/utf_string_conversions.h"
+#include "net/base/escape.h"
+
+namespace {
+
+std::string GetComponent(const std::string& url,
+                         const url::Component component) {
+  return (component.len > 0) ? url.substr(component.begin, component.len) :
+      std::string();
+}
+
+}  // namespace
+
 InstantSuggestion::InstantSuggestion() {
 }
 
 InstantSuggestion::InstantSuggestion(const base::string16& in_text,
                                      const std::string& in_metadata)
     : text(in_text),
       metadata(in_metadata) {
 }
 
 InstantSuggestion::~InstantSuggestion() {
@@ skipping 44 matching lines @@
       header_color == rhs.header_color &&
       section_border_color == rhs.section_border_color &&
       theme_id == rhs.theme_id &&
       image_horizontal_alignment == rhs.image_horizontal_alignment &&
       image_vertical_alignment == rhs.image_vertical_alignment &&
       image_tiling == rhs.image_tiling &&
       image_height == rhs.image_height &&
       has_attribution == rhs.has_attribution &&
       logo_alternate == rhs.logo_alternate;
 }
+
+const char kSearchQueryKey[] = "q";
+const char kOriginalQueryKey[] = "oq";
+const char kRLZParameterKey[] = "rlz";
+const char kInputEncodingKey[] = "ie";
+const char kAssistedQueryStatsKey[] = "aqs";
+
+EmbeddedSearchRequestParams::EmbeddedSearchRequestParams() {
+}
+
+EmbeddedSearchRequestParams::EmbeddedSearchRequestParams(const GURL& url) {

[Mark P, 2014/11/17 19:15:59]

Can you add a simple test for this that show it extracts all parameters (with +
and space and whatever as you'd expect from a Google search URL)?

[kmadhusu, 2014/11/17 22:52:05]

Done.

+  const std::string& url_params(url.query());
+  url::Component query, key, value;
+  query.len = static_cast<int>(url_params.size());
+
+  net::UnescapeRule::Type unescape_rules =

[Mark P, 2014/11/17 19:15:59]

nit: might as well be const

[kmadhusu, 2014/11/17 22:52:05]

Done.

+      net::UnescapeRule::CONTROL_CHARS | net::UnescapeRule::SPACES |
+      net::UnescapeRule::URL_SPECIAL_CHARS | net::UnescapeRule::NORMAL |
+      net::UnescapeRule::REPLACE_PLUS_WITH_SPACE;
+
+  while (url::ExtractQueryKeyValue(url_params.c_str(), &query, &key, &value)) {
+    if (!key.is_nonempty())
+      continue;
+
+    std::string key_param(GetComponent(url_params, key));
+    std::string value_param(GetComponent(url_params, value));
+    if (key_param == kSearchQueryKey) {
+      search_query = base::UTF8ToUTF16(net::UnescapeURLComponent(
+          value_param, unescape_rules));
+    } else if (key_param == kOriginalQueryKey) {
+      original_query = base::UTF8ToUTF16(net::UnescapeURLComponent(
+          value_param, unescape_rules));
+    } else if (key_param == kRLZParameterKey) {
+      rlz_parameter_value =net::UnescapeAndDecodeUTF8URLComponent(

[Mark P, 2014/11/17 19:15:59]

nit: "=n" -> "= n"

[kmadhusu, 2014/11/17 22:52:05]

Done.

+          value_param, net::UnescapeRule::NORMAL);
+    } else if (key_param == kInputEncodingKey) {
+      input_encoding = net::UnescapeAndDecodeUTF8URLComponent(
+          value_param, net::UnescapeRule::NORMAL);
+    } else if (key_param == kAssistedQueryStatsKey) {
+      assisted_query_stats = net::UnescapeAndDecodeUTF8URLComponent(
+          value_param, net::UnescapeRule::NORMAL);
+    }
+  }
+}
+
+EmbeddedSearchRequestParams::~EmbeddedSearchRequestParams() {
+}