Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 609463003: Hydrogenize (and share) part of StoreTransition handler as a StoreTransitionStub. (Closed)

Created:
6 years, 2 months ago by Igor Sheludko
Modified:
6 years, 2 months ago
Reviewers:
Yang, Toon Verwaest
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Hydrogenize (and share) part of StoreTransition handler as a StoreTransitionStub and StoreField handler simplification. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24333

Patch Set 1 #

Patch Set 2 : Further simplification #

Total comments: 4

Patch Set 3 : Addressed comments #

Patch Set 4 : Rebasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+317 lines, -1204 lines) Patch
M src/arm/interface-descriptors-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/code-stubs.h View 1 2 3 3 chunks +25 lines, -9 lines 0 comments Download
M src/code-stubs.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 2 3 1 chunk +47 lines, -35 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/arm/handler-compiler-arm.cc View 1 1 chunk +27 lines, -168 lines 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 1 1 chunk +27 lines, -162 lines 0 comments Download
M src/ic/handler-compiler.h View 1 1 chunk +7 lines, -8 lines 0 comments Download
M src/ic/handler-compiler.cc View 1 2 3 2 chunks +40 lines, -6 lines 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 1 1 chunk +25 lines, -153 lines 0 comments Download
M src/ic/mips/handler-compiler-mips.cc View 1 2 3 1 chunk +28 lines, -172 lines 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 1 2 3 1 chunk +28 lines, -171 lines 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 1 1 chunk +25 lines, -152 lines 0 comments Download
M src/ic/x87/handler-compiler-x87.cc View 1 1 chunk +25 lines, -155 lines 0 comments Download
M src/interface-descriptors.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/interface-descriptors.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Igor Sheludko
PTAL
6 years, 2 months ago (2014-09-26 08:52:39 UTC) #2
Yang
On 2014/09/26 08:52:39, Igor Sheludko wrote: > PTAL lgtm.
6 years, 2 months ago (2014-09-30 11:56:45 UTC) #3
Yang
https://codereview.chromium.org/609463003/diff/20001/src/code-stubs.h File src/code-stubs.h (right): https://codereview.chromium.org/609463003/diff/20001/src/code-stubs.h#newcode86 src/code-stubs.h:86: V(StoreTransition) \ alpha-sort. https://codereview.chromium.org/609463003/diff/20001/src/code-stubs.h#newcode985 src/code-stubs.h:985: // Extend storage is ...
6 years, 2 months ago (2014-09-30 11:56:53 UTC) #4
Igor Sheludko
Committed patchset #4 (id:80001) manually as 24333 (presubmit successful).
6 years, 2 months ago (2014-09-30 14:54:41 UTC) #6
Igor Sheludko
6 years, 2 months ago (2014-09-30 14:54:53 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/609463003/diff/20001/src/code-stubs.h
File src/code-stubs.h (right):

https://codereview.chromium.org/609463003/diff/20001/src/code-stubs.h#newcode86
src/code-stubs.h:86: V(StoreTransition)                        \
On 2014/09/30 11:56:53, Yang wrote:
> alpha-sort.

Done.

https://codereview.chromium.org/609463003/diff/20001/src/code-stubs.h#newcode985
src/code-stubs.h:985: // Extend storage is called in a store inline cache when
On 2014/09/30 11:56:53, Yang wrote:
> not sure if comment outdated.

Done.

Powered by Google App Engine
This is Rietveld 408576698