Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 609463002: Don't include nested outlines when computing repaint rects for SVG objects (Closed)

Created:
6 years, 2 months ago by fs
Modified:
6 years, 2 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, rwlbuis, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, Stephen Chennney, pdr+svgwatchlist_chromium.org, rune+blink
Project:
blink
Visibility:
Public.

Description

Don't include nested outlines when computing repaint rects for SVG objects Because the paint invalidation rect is inflated in SVGRenderSupport::computeFloatRectForPaintInvalidation, rather than in clippedOverflowRectForPaintInvalidation (for example) the repaint rect being computed includes outlines from all (SVG) ancestors. Hoist the 'inflation' out of computeFloatRectForPaintInvalidation (both the SVGRenderSupport one and its callers). BUG=417729 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182744

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -3 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +2 lines, -0 lines 0 comments Download
A LayoutTests/svg/repaint/shape-with-nested-outline.html View 1 chunk +30 lines, -0 lines 0 comments Download
A + LayoutTests/svg/repaint/shape-with-nested-outline-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGForeignObject.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGText.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/svg/SVGRenderSupport.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fs
Discovered while working on https://codereview.chromium.org/598623002/. Could probably be taken further, but it seemed more safe ...
6 years, 2 months ago (2014-09-25 16:05:42 UTC) #2
f(malita)
lgtm
6 years, 2 months ago (2014-09-25 16:53:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/609463002/1
6 years, 2 months ago (2014-09-26 08:26:13 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 09:16:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 182744

Powered by Google App Engine
This is Rietveld 408576698