Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1420)

Unified Diff: content/renderer/push_messaging_dispatcher.h

Issue 609393002: [Push] Use Manifest.gcm_sender_id instead of API sender_id if possible. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@manifest_gcm_sender_id
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/push_messaging_dispatcher.h
diff --git a/content/renderer/push_messaging_dispatcher.h b/content/renderer/push_messaging_dispatcher.h
index 33ac7bde97a43aa29da52efb07f2560e8d02ecb1..70ec977da50f68486521c4f0c6abf9a38c5f5251 100644
--- a/content/renderer/push_messaging_dispatcher.h
+++ b/content/renderer/push_messaging_dispatcher.h
@@ -24,6 +24,9 @@ class WebString;
} // namespace blink
namespace content {
+
+struct Manifest;
+
class PushMessagingDispatcher : public RenderFrameObserver,
public blink::WebPushClient {
public:
@@ -35,16 +38,16 @@ class PushMessagingDispatcher : public RenderFrameObserver,
virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
// WebPushClient implementation.
- // TODO(mvanouwerkerk): Delete this method once its callers are gone and
- // WebPushClient no longer defines it (as pure virtual).
- virtual void registerPushMessaging(
- const blink::WebString& sender_id,
- blink::WebPushRegistrationCallbacks* callbacks);
virtual void registerPushMessaging(
const blink::WebString& sender_id,
blink::WebPushRegistrationCallbacks* callbacks,
blink::WebServiceWorkerProvider* service_worker_provider);
+ void DoRegister(const std::string& sender_id,
+ blink::WebPushRegistrationCallbacks* callbacks,
+ blink::WebServiceWorkerProvider* service_worker_provider,
+ const Manifest& manifest);
+
void OnRegisterSuccess(int32 callbacks_id,
const GURL& endpoint,
const std::string& registration_id);
« no previous file with comments | « no previous file | content/renderer/push_messaging_dispatcher.cc » ('j') | content/renderer/push_messaging_dispatcher.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698