[Push] Use Manifest.gcm_sender_id instead of API sender_id if possible.

[Push] Use Manifest.gcm_sender_id instead of API sender_id if possible.

PushMessagingDispatcher is now trying to get the Manifest before
asking the registration to happen. If the gcm_sender_id is set, it will
be used. Otherwise, the flow is unchanged.

This is an considered option in order to no longer require an opaque
property bag to be passed when registering. It might or might not stay
as is.

BUG=414873
Committed: https://crrev.com/4fff199018de7d518127d1fa29e4d38c9242642f
Cr-Commit-Position: refs/heads/master@{#297403}

[mlamouri (slow - plz ping), 2014-09-29 16:32:22]

mlamouri@chromium.org changed reviewers:
+ mvanouwerkerk@chromium.org

[mlamouri (slow - plz ping), 2014-09-29 17:45:48]

mlamouri@chromium.org changed reviewers:
+ avi@chromium.org

[Avi (use Gerrit), 2014-09-29 17:56:47]

OWNER lgtm stamp; get approval from the area expert before landing.

[Michael van Ouwerkerk, 2014-09-29 18:11:48]

lgtm with nits

https://codereview.chromium.org/609393002/diff/1/content/renderer/push_messag...
File content/renderer/push_messaging_dispatcher.cc (right):

https://codereview.chromium.org/609393002/diff/1/content/renderer/push_messag...
content/renderer/push_messaging_dispatcher.cc:46: DCHECK(render_frame_impl);
Let's not DCHECK here as the dispatcher is owned by the frame.

https://codereview.chromium.org/609393002/diff/1/content/renderer/push_messag...
content/renderer/push_messaging_dispatcher.cc:49: DCHECK(manifest_manager);
Ditto here.

https://codereview.chromium.org/609393002/diff/1/content/renderer/push_messag...
content/renderer/push_messaging_dispatcher.cc:51:
manifest_manager->GetManifest(base::Bind(&PushMessagingDispatcher::DoRegister,
Then collapse this to render_frame_impl->manifest_manager()->GetManifest(...)

[mlamouri (slow - plz ping), 2014-09-30 09:44:52]

https://codereview.chromium.org/609393002/diff/1/content/renderer/push_messag...
File content/renderer/push_messaging_dispatcher.cc (right):

https://codereview.chromium.org/609393002/diff/1/content/renderer/push_messag...
content/renderer/push_messaging_dispatcher.cc:46: DCHECK(render_frame_impl);
On 2014/09/29 18:11:48, Michael van Ouwerkerk wrote:
> Let's not DCHECK here as the dispatcher is owned by the frame.

Done.

https://codereview.chromium.org/609393002/diff/1/content/renderer/push_messag...
content/renderer/push_messaging_dispatcher.cc:49: DCHECK(manifest_manager);
On 2014/09/29 18:11:48, Michael van Ouwerkerk wrote:
> Ditto here.

Done.

https://codereview.chromium.org/609393002/diff/1/content/renderer/push_messag...
content/renderer/push_messaging_dispatcher.cc:51:
manifest_manager->GetManifest(base::Bind(&PushMessagingDispatcher::DoRegister,
On 2014/09/29 18:11:48, Michael van Ouwerkerk wrote:
> Then collapse this to render_frame_impl->manifest_manager()->GetManifest(...)

I collapsed everything.

[mlamouri (slow - plz ping), 2014-09-30 09:46:51]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2014-09-30 09:48:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/609393002/20001

[commit-bot: I haz the power, 2014-09-30 11:22:54]

Committed patchset #2 (id:20001) as e44b51a6b786902c9357f559f6171186886abd74

[commit-bot: I haz the power, 2014-09-30 11:23:34]

Patchset 2 (id:??) landed as
https://crrev.com/4fff199018de7d518127d1fa29e4d38c9242642f
Cr-Commit-Position: refs/heads/master@{#297403}