Wire up uma histograms with webrtc.

Wire up uma histograms with webrtc.

Tested with chrome://histograms and verified that values from webrtc propagated to histograms.

BUG=419657
Committed: https://crrev.com/33a426524a82e5d79f5df64336abf66f0919f943
Cr-Commit-Position: refs/heads/master@{#300449}

[asapersson2, 2014-09-30 07:40:34]

asapersson@chromium.org changed reviewers:
+ andresp@chromium.org

[andresp-chromium, 2014-09-30 14:56:36]

On 2014/09/30 07:40:34, asapersson2 wrote:
> mailto:asapersson@chromium.org changed reviewers:
> + mailto:andresp@chromium.org

This CL looks good to me.. missing:

- A bug to be able to track work whenever someone digs these CLS.

- A description on how this was tested if it was tested.
  Don't forget to lookup on chrome://histograms to see if values from webrtc
actually propagated till here.

[asapersson2, 2014-10-03 11:33:23]

On 2014/09/30 14:56:36, andresp wrote:
> On 2014/09/30 07:40:34, asapersson2 wrote:
> > mailto:asapersson@chromium.org changed reviewers:
> > + mailto:andresp@chromium.org
> 
> This CL looks good to me.. missing:
> 
> - A bug to be able to track work whenever someone digs these CLS.
> 
> - A description on how this was tested if it was tested.
>   Don't forget to lookup on chrome://histograms to see if values from webrtc
> actually propagated till here.

Tested with chrome://histograms and verified that the values propagated.

[asapersson2, 2014-10-03 11:33:51]

asapersson@chromium.org changed reviewers:
+ tommi@chromium.org

[andresp-chromium, 2014-10-03 11:37:23]

lgtm (some nits).

https://codereview.chromium.org/609353002/diff/40001/third_party/libjingle/ov...
File third_party/libjingle/overrides/init_webrtc.cc (right):

https://codereview.chromium.org/609353002/diff/40001/third_party/libjingle/ov...
third_party/libjingle/overrides/init_webrtc.cc:46: // Define webrtc:metrics
functions to provide webrtc with implementations.
nit: webrtc::metrics

Also both here and in the other file the metrics namespace could be inside the
webrtc namespace opened for the purpose of field_trials.

[andresp-chromium, 2014-10-03 11:37:49]

On 2014/10/03 11:37:23, andresp wrote:
> lgtm (some nits).
> 
>
https://codereview.chromium.org/609353002/diff/40001/third_party/libjingle/ov...
> File third_party/libjingle/overrides/init_webrtc.cc (right):
> 
>
https://codereview.chromium.org/609353002/diff/40001/third_party/libjingle/ov...
> third_party/libjingle/overrides/init_webrtc.cc:46: // Define webrtc:metrics
> functions to provide webrtc with implementations.
> nit: webrtc::metrics
> 
> Also both here and in the other file the metrics namespace could be inside the
> webrtc namespace opened for the purpose of field_trials.

Please add a "Tested" description in the cl description and not only on the
comments.

[asapersson2, 2014-10-03 12:08:41]

https://codereview.chromium.org/609353002/diff/40001/third_party/libjingle/ov...
File third_party/libjingle/overrides/init_webrtc.cc (right):

https://codereview.chromium.org/609353002/diff/40001/third_party/libjingle/ov...
third_party/libjingle/overrides/init_webrtc.cc:46: // Define webrtc:metrics
functions to provide webrtc with implementations.
On 2014/10/03 11:37:22, andresp wrote:
> nit: webrtc::metrics
> 
> Also both here and in the other file the metrics namespace could be inside the
> webrtc namespace opened for the purpose of field_trials.

Done.

[asapersson2, 2014-10-03 18:46:52]

On 2014/10/03 12:08:41, asapersson2 wrote:
>
https://codereview.chromium.org/609353002/diff/40001/third_party/libjingle/ov...
> File third_party/libjingle/overrides/init_webrtc.cc (right):
> 
>
https://codereview.chromium.org/609353002/diff/40001/third_party/libjingle/ov...
> third_party/libjingle/overrides/init_webrtc.cc:46: // Define webrtc:metrics
> functions to provide webrtc with implementations.
> On 2014/10/03 11:37:22, andresp wrote:
> > nit: webrtc::metrics
> > 
> > Also both here and in the other file the metrics namespace could be inside
the
> > webrtc namespace opened for the purpose of field_trials.
> 
> Done.

I think there may be an issue with this solution. I will continue to work on it.

[asapersson2, 2014-10-09 12:17:00]

Patchset #7 (id:120001) has been deleted

[asapersson2, 2014-10-09 14:19:20]

On 2014/10/03 18:46:52, asapersson2 wrote:
> On 2014/10/03 12:08:41, asapersson2 wrote:
> >
>
https://codereview.chromium.org/609353002/diff/40001/third_party/libjingle/ov...
> > File third_party/libjingle/overrides/init_webrtc.cc (right):
> > 
> >
>
https://codereview.chromium.org/609353002/diff/40001/third_party/libjingle/ov...
> > third_party/libjingle/overrides/init_webrtc.cc:46: // Define webrtc:metrics
> > functions to provide webrtc with implementations.
> > On 2014/10/03 11:37:22, andresp wrote:
> > > nit: webrtc::metrics
> > > 
> > > Also both here and in the other file the metrics namespace could be inside
> the
> > > webrtc namespace opened for the purpose of field_trials.
> > 
> > Done.
> 
> I think there may be an issue with this solution. I will continue to work on
it.

Have updated the CL. PTAL.

[asapersson2, 2014-10-09 15:18:36]

Patchset #7 (id:140001) has been deleted

[asapersson2, 2014-10-09 15:21:47]

Patchset #7 (id:160001) has been deleted

[asapersson2, 2014-10-14 06:41:47]

Patchset #7 (id:180001) has been deleted

[asapersson2, 2014-10-20 09:35:45]

Patchset #7 (id:200001) has been deleted

[tommi (sloooow) - chröme, 2014-10-20 09:54:32]

can you run try bots?  otherwise it looks good.

https://codereview.chromium.org/609353002/diff/220001/third_party/libjingle/o...
File third_party/libjingle/overrides/init_webrtc.h (right):

https://codereview.chromium.org/609353002/diff/220001/third_party/libjingle/o...
third_party/libjingle/overrides/init_webrtc.h:59: typedef bool
(*InitializeModuleFunction)(
Can you add a TODO here for me to use a struct for this? The number of functions
is growing to be pretty big.

[asapersson2, 2014-10-21 09:57:30]

https://codereview.chromium.org/609353002/diff/220001/third_party/libjingle/o...
File third_party/libjingle/overrides/init_webrtc.h (right):

https://codereview.chromium.org/609353002/diff/220001/third_party/libjingle/o...
third_party/libjingle/overrides/init_webrtc.h:59: typedef bool
(*InitializeModuleFunction)(
On 2014/10/20 09:54:32, tommi wrote:
> Can you add a TODO here for me to use a struct for this? The number of
functions
> is growing to be pretty big.

Done.

[tommi (sloooow) - chröme, 2014-10-21 10:00:19]

The CQ bit was checked by tommi@chromium.org

[tommi (sloooow) - chröme, 2014-10-21 10:00:20]

lgtm

[commit-bot: I haz the power, 2014-10-21 10:00:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/609353002/240001

[commit-bot: I haz the power, 2014-10-21 11:01:47]

Committed patchset #8 (id:240001)

[commit-bot: I haz the power, 2014-10-21 11:03:17]

Patchset 8 (id:??) landed as
https://crrev.com/33a426524a82e5d79f5df64336abf66f0919f943
Cr-Commit-Position: refs/heads/master@{#300449}

[asapersson2, 2014-10-29 11:11:11]

Patchset #9 (id:260001) has been deleted