Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 60933003: Set the skia glyph cache count limit to 64 (Closed)

Created:
7 years, 1 month ago by jamesr
Modified:
7 years, 1 month ago
CC:
chromium-reviews, tonyg
Visibility:
Public.

Description

Set the skia glyph cache count limit to 64 The skia glyph cache can use up to 4 GDI handles per cache entry (1 HFONT, 1 HBITMAP, 2 HDCs). There's a global (session-wide) limit of GDI handles at 10k on some version of windows, so we need to keep the per-process handle count well below this limit to avoid exhaustion. This sets the limit at 64 cache entries so the skia glyph cache will stay under ~256 handles per process. BUG=314387 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233531

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M skia/skia_library.gypi View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
jamesr
PTAL. We'll see how this behaves on the perf bots and adjust if necessary.
7 years, 1 month ago (2013-11-05 23:27:27 UTC) #1
tonyg
[+perf sheriff heads up] lgtm
7 years, 1 month ago (2013-11-06 00:09:04 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm
7 years, 1 month ago (2013-11-06 03:11:35 UTC) #3
jamesr
Mike - need your stamp here (or someone else in the skia/ OWNERS file).
7 years, 1 month ago (2013-11-06 18:16:17 UTC) #4
reed1
lgtm
7 years, 1 month ago (2013-11-06 19:32:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/60933003/100001
7 years, 1 month ago (2013-11-06 20:22:17 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests, chrome_frame_net_tests, chrome_frame_tests, chrome_frame_unittests, content_browsertests, mini_installer_test, ...
7 years, 1 month ago (2013-11-06 23:29:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/60933003/100001
7 years, 1 month ago (2013-11-06 23:46:56 UTC) #8
commit-bot: I haz the power
7 years, 1 month ago (2013-11-07 07:42:04 UTC) #9
Message was sent while issue was closed.
Change committed as 233531

Powered by Google App Engine
This is Rietveld 408576698