Issue 609293004: Convert various media options into proper declare_args().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 609293004: Convert various media options into proper declare_args(). (Closed)

Created:
6 years, 2 months ago by DaleCurtis

Modified:
6 years, 2 months ago

Reviewers:
brettw

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Convert various media options into proper declare_args(). BUG=none TEST=gn gen. Committed: https://crrev.com/a36cfd327476cc84febd6d511d61043d08c87cd2 Cr-Commit-Position: refs/heads/master@{#297449}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+51 lines, -39 lines)			Patch
M	media/BUILD.gn	View	1 chunk	+1 line, -1 line	0 comments	Download
M	media/audio/BUILD.gn	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	media/media_options.gni	View	1 chunk	+48 lines, -36 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/609293004/1

6 years, 2 months ago (2014-09-30 17:24:39 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as 0a6e17bf3854907e20243c44f4f8b19cec2845f8

6 years, 2 months ago (2014-09-30 18:01:31 UTC) #6

commit-bot: I haz the power

6 years, 2 months ago (2014-09-30 18:02:02 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/a36cfd327476cc84febd6d511d61043d08c87cd2
Cr-Commit-Position: refs/heads/master@{#297449}