Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 609293002: Video Player: Update the design of cast menu. (Closed)

Created:
6 years, 2 months ago by fukino
Modified:
6 years, 2 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, feature-media-reviews_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Video Player: Update the design of cast menu. BUG=417113 TEST=manually tested. Committed: https://crrev.com/bdb453be60703048994273952b14eab901e8894b Cr-Commit-Position: refs/heads/master@{#297377}

Patch Set 1 #

Patch Set 2 : Reflected sgabriel@'s comments on the issue. #

Total comments: 2

Patch Set 3 : Add bug number. #

Patch Set 4 : Edited the comment slightly. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -25 lines) Patch
M ui/file_manager/video_player/css/cast_menu.css View 1 2 3 2 chunks +42 lines, -25 lines 0 comments Download
A ui/file_manager/video_player/images/media/2x/media_check.png View Binary file 0 comments Download
A ui/file_manager/video_player/images/media/media_check.png View Binary file 0 comments Download

Messages

Total messages: 9 (2 generated)
fukino
yoshiki@, could you take a look? I attached a screenshot of the current design in ...
6 years, 2 months ago (2014-09-29 09:08:53 UTC) #2
fukino
yoshiki@, I updated the design based on comments in the issue. Could you take a ...
6 years, 2 months ago (2014-09-30 06:32:15 UTC) #3
yoshiki
lgtm https://codereview.chromium.org/609293002/diff/20001/ui/file_manager/video_player/css/cast_menu.css File ui/file_manager/video_player/css/cast_menu.css (right): https://codereview.chromium.org/609293002/diff/20001/ui/file_manager/video_player/css/cast_menu.css#newcode29 ui/file_manager/video_player/css/cast_menu.css:29: /* Make the bottom border's width one device ...
6 years, 2 months ago (2014-09-30 06:42:28 UTC) #4
fukino
Thank you for quick review! https://codereview.chromium.org/609293002/diff/20001/ui/file_manager/video_player/css/cast_menu.css File ui/file_manager/video_player/css/cast_menu.css (right): https://codereview.chromium.org/609293002/diff/20001/ui/file_manager/video_player/css/cast_menu.css#newcode29 ui/file_manager/video_player/css/cast_menu.css:29: /* Make the bottom ...
6 years, 2 months ago (2014-09-30 06:59:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/609293002/60001
6 years, 2 months ago (2014-09-30 07:02:38 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 5bfbcf850fa493db0a84b27dc7b4864bdc4a5e09
6 years, 2 months ago (2014-09-30 07:37:20 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 07:38:29 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/bdb453be60703048994273952b14eab901e8894b
Cr-Commit-Position: refs/heads/master@{#297377}

Powered by Google App Engine
This is Rietveld 408576698