Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 609253002: Fix initialization of assert scopes. (Closed)

Created:
6 years, 2 months ago by Benedikt Meurer
Modified:
6 years, 2 months ago
Reviewers:
dcarney, Jakob Kummerow
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix initialization of assert scopes. The thread local key for assert scopes can be lazily initialized and should be independent of the Isolate initialization. Also cleanup the assert-scope.{cc,h} implementation while I was at it. R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24275

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -117 lines) Patch
M src/assert-scope.h View 1 2 chunks +16 lines, -99 lines 0 comments Download
M src/assert-scope.cc View 1 1 chunk +141 lines, -7 lines 0 comments Download
M src/isolate.cc View 1 2 chunks +0 lines, -7 lines 0 comments Download
M src/test/run-all-unittests.cc View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
PTAL
6 years, 2 months ago (2014-09-29 04:28:09 UTC) #1
dcarney
lgtm
6 years, 2 months ago (2014-09-29 09:30:30 UTC) #2
Benedikt Meurer
6 years, 2 months ago (2014-09-29 09:39:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24275 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698