Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: chrome/browser/signin/signin_browsertest.cc

Issue 60923002: [sync] Allow FakeURLFetcher to return an arbitrary URLRequestStatus (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/signin/signin_browsertest.cc
diff --git a/chrome/browser/signin/signin_browsertest.cc b/chrome/browser/signin/signin_browsertest.cc
index aebd1f8432b38552bc9996a62147aea1a1247eb8..a8f5395acb158cb501f06e980367632e48e0e846 100644
--- a/chrome/browser/signin/signin_browsertest.cc
+++ b/chrome/browser/signin/signin_browsertest.cc
@@ -27,6 +27,7 @@
#include "google_apis/gaia/gaia_urls.h"
#include "net/http/http_status_code.h"
#include "net/url_request/test_url_fetcher_factory.h"
+#include "net/url_request/url_request_status.h"
namespace {
const char kNonSigninURL[] = "www.google.com";
@@ -55,12 +56,11 @@ class SigninBrowserTest : public InProcessBrowserTest {
factory_.reset(new net::URLFetcherImplFactory());
fake_factory_.reset(new net::FakeURLFetcherFactory(factory_.get()));
fake_factory_->SetFakeResponse(
- GaiaUrls::GetInstance()->service_login_url(),
- std::string(),
- net::HTTP_OK);
- fake_factory_->SetFakeResponse(GURL(kNonSigninURL),
- std::string(),
- net::HTTP_OK);
+ GaiaUrls::GetInstance()->service_login_url(), std::string(),
+ net::HTTP_OK, net::URLRequestStatus::SUCCESS);
+ fake_factory_->SetFakeResponse(
+ GURL(kNonSigninURL), std::string(), net::HTTP_OK,
+ net::URLRequestStatus::SUCCESS);
// Yield control back to the InProcessBrowserTest framework.
InProcessBrowserTest::SetUp();
}

Powered by Google App Engine
This is Rietveld 408576698