chrome/browser/notifications/sync_notifier/notification_bitmap_fetcher_browsertest.cc - Issue 60923002: [sync] Allow FakeURLFetcher to return an arbitrary URLRequestStatus

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/sync_notifier/notification_bitmap_fetcher_browsertest.cc

Issue 60923002: [sync] Allow FakeURLFetcher to return an arbitrary URLRequestStatus (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest.cc ('k') | chrome/browser/profile_resetter/profile_resetter_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/sync_notifier/notification_bitmap_fetcher_browsertest.cc

diff --git a/chrome/browser/notifications/sync_notifier/notification_bitmap_fetcher_browsertest.cc b/chrome/browser/notifications/sync_notifier/notification_bitmap_fetcher_browsertest.cc

index ceca2cf1eca309670973bded7612583f185e6cda..35a95bbe77a1b7a71ea0e704932313aea19ecf66 100644

--- a/chrome/browser/notifications/sync_notifier/notification_bitmap_fetcher_browsertest.cc

+++ b/chrome/browser/notifications/sync_notifier/notification_bitmap_fetcher_browsertest.cc

@@ -12,6 +12,7 @@

#include "net/http/http_status_code.h"

#include "net/url_request/test_url_fetcher_factory.h"

#include "net/url_request/url_fetcher.h"

+#include "net/url_request/url_request_status.h"

#include "testing/gtest/include/gtest/gtest.h"

#include "third_party/skia/include/core/SkBitmap.h"

#include "ui/gfx/codec/png_codec.h"

@@ -111,7 +112,8 @@ IN_PROC_BROWSER_TEST_F(NotificationBitmapFetcherBrowserTest,

NotificationBitmapFetcher fetcher(url, &delegate);

- url_fetcher_factory_->SetFakeResponse(url, image_string, net::HTTP_OK);

+ url_fetcher_factory_->SetFakeResponse(url, image_string, net::HTTP_OK,

+ net::URLRequestStatus::SUCCESS);

// We expect that the image decoder will get called and return

// an image in a callback to OnImageDecoded().

@@ -163,7 +165,8 @@ IN_PROC_BROWSER_TEST_F(NotificationBitmapFetcherBrowserTest,

url_fetcher_factory_->SetFakeResponse(url,

std::string(),

- net::HTTP_INTERNAL_SERVER_ERROR);

+ net::HTTP_INTERNAL_SERVER_ERROR,

+ net::URLRequestStatus::FAILED);

fetcher.Start(browser()->profile());

@@ -179,7 +182,8 @@ IN_PROC_BROWSER_TEST_F(NotificationBitmapFetcherBrowserTest,

NotificationBitmapFetcherTestDelegate delegate(kAsyncCall);

NotificationBitmapFetcher fetcher(url, &delegate);

url_fetcher_factory_->SetFakeResponse(

- url, std::string("Not a real bitmap"), net::HTTP_OK);

+ url, std::string("Not a real bitmap"),

+ net::HTTP_OK, net::URLRequestStatus::SUCCESS);

fetcher.Start(browser()->profile());