Write buffer based write barrier for IA32 and Crankshaft. Currently...

src/ia32/stub-cache-ia32.cc

Index: src/ia32/stub-cache-ia32.cc
===================================================================
--- src/ia32/stub-cache-ia32.cc	(revision 6183)
+++ src/ia32/stub-cache-ia32.cc	(working copy)
@@ -818,12 +818,10 @@
     int offset = object->map()->instance_size() + (index * kPointerSize);
     __ mov(FieldOperand(receiver_reg, offset), eax);
 
-#ifdef ENABLE_CARDMARKING_WRITE_BARRIER
     // Update the write barrier for the array address.
     // Pass the value being stored in the now unused name_reg.
     __ mov(name_reg, Operand(eax));
-    __ RecordWrite(receiver_reg, offset, name_reg, scratch);
-#endif
+    __ RecordWrite(receiver_reg, offset, name_reg, scratch, kDontSaveFPRegs);
   } else {
     // Write to the properties array.
     int offset = index * kPointerSize + FixedArray::kHeaderSize;
@@ -831,12 +829,10 @@
     __ mov(scratch, FieldOperand(receiver_reg, JSObject::kPropertiesOffset));
     __ mov(FieldOperand(scratch, offset), eax);
 
-#ifdef ENABLE_CARDMARKING_WRITE_BARRIER
     // Update the write barrier for the array address.
     // Pass the value being stored in the now unused name_reg.
     __ mov(name_reg, Operand(eax));
-    __ RecordWrite(scratch, offset, name_reg, receiver_reg);
-#endif
+    __ RecordWrite(scratch, offset, name_reg, receiver_reg, kDontSaveFPRegs);
   }
 
   // Return the value (register eax).
@@ -1483,9 +1479,7 @@
 
     if (argc == 1) {  // Otherwise fall through to call builtin.
       Label exit, attempt_to_grow_elements;
-#ifdef ENABLE_CARDMARKING_WRITE_BARRIER
       Label with_write_barrier;
-#endif
 
       // Get the array's length into eax and calculate new length.
       __ mov(eax, FieldOperand(edx, JSArray::kLengthOffset));
@@ -1510,23 +1504,19 @@
       __ mov(ecx, Operand(esp, argc * kPointerSize));
       __ mov(Operand(edx, 0), ecx);
 
-#ifdef ENABLE_CARDMARKING_WRITE_BARRIER
       // Check if value is a smi.
       __ test(ecx, Immediate(kSmiTagMask));
       __ j(not_zero, &with_write_barrier);
-#endif
 
       __ bind(&exit);
       __ ret((argc + 1) * kPointerSize);
 
-#ifdef ENABLE_CARDMARKING_WRITE_BARRIER
       __ bind(&with_write_barrier);
 
       __ InNewSpace(ebx, ecx, equal, &exit);
 
-      __ RecordWriteHelper(ebx, edx, ecx);
+      __ RecordWriteHelper(ebx, edx, ecx, kDontSaveFPRegs);
       __ ret((argc + 1) * kPointerSize);
-#endif
 
       __ bind(&attempt_to_grow_elements);
       if (!FLAG_inline_new) {
@@ -2695,9 +2685,7 @@
   // the value in register eax.
   __ mov(edx, Operand(eax));
   __ mov(FieldOperand(edi, ecx, times_2, FixedArray::kHeaderSize), eax);
-#ifdef ENABLE_CARDMARKING_WRITE_BARRIER
-  __ RecordWrite(edi, 0, edx, ecx);
-#endif
+  __ RecordWrite(edi, 0, edx, ecx, kDontSaveFPRegs);
 
   // Done.
   __ ret(0);