Issue 609153002: [SyncFS] Use variadic template in callback_helper.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 609153002: [SyncFS] Use variadic template in callback_helper.h (Closed)

Created:
6 years, 2 months ago by tzik

Modified:
6 years, 2 months ago

Reviewers:
peria

CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik

Base URL:
https://chromium.googlesource.com/chromium/src.git@scoped_ptr

Project:
chromium

Visibility:
Public.

[SyncFS] Use variadic template in callback_helper.h BUG=None Committed: https://crrev.com/3d756885aaffca19df8fa8f9399a9cf1ca73871d Cr-Commit-Position: refs/heads/master@{#297134}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -208 lines)			Patch
	M	chrome/browser/sync_file_system/drive_backend/callback_helper.h	View		2 chunks	+6 lines, -81 lines	0 comments	Download
	D	chrome/browser/sync_file_system/drive_backend/callback_helper.h.pump	View		1 chunk	+0 lines, -127 lines	0 comments	Download

Total messages: 7 (2 generated)

tzik

PTL. Now we can use variadic template. It's time to retire pump-generated sources.

6 years, 2 months ago (2014-09-29 01:58:58 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/609153002/1

6 years, 2 months ago (2014-09-29 03:04:18 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as c3f3acd1b742601cad2ad2b0a58326de7a3ff62a

6 years, 2 months ago (2014-09-29 03:47:23 UTC) #6

commit-bot: I haz the power

6 years, 2 months ago (2014-09-29 03:50:55 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/3d756885aaffca19df8fa8f9399a9cf1ca73871d
Cr-Commit-Position: refs/heads/master@{#297134}