Issue 609083002: Store the result of Pass() in a local variable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 609083002: Store the result of Pass() in a local variable. (Closed)

Created:
6 years, 2 months ago by danakj

Modified:
6 years, 2 months ago

Reviewers:
sky

CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org, dcheng, jamesr, mazda, piman

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Store the result of Pass() in a local variable. This makes the use of Pass() similar to how std::move() would be used to make this code act as it should when using unique_ptr. R=sky@chromium.org BUG=418297 Committed: https://crrev.com/514a30a4f290e598ee7e2b00072fe3dad71cbed1 Cr-Commit-Position: refs/heads/master@{#297214}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	ash/drag_drop/drag_drop_controller.cc	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/609083002/20001

6 years, 2 months ago (2014-09-29 18:35:51 UTC) #4

commit-bot: I haz the power

Committed patchset #2 (id:20001) as 89d411d84635ecfb625e6c35d49e65ef9b34ecf6

6 years, 2 months ago (2014-09-29 18:40:50 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-09-29 18:41:32 UTC) #6

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/514a30a4f290e598ee7e2b00072fe3dad71cbed1
Cr-Commit-Position: refs/heads/master@{#297214}