Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issue 609033002: Revert of Mojo: Convert some scoped_ptr<...>(new ...) to make_scoped_ptr(new ...) in mojo/{embedder,system}. (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
jamesr, viettrungluu
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Mojo: Convert some scoped_ptr<...>(new ...) to make_scoped_ptr(new ...) in mojo/{embedder,system}. (patchset #2 id:20001 of https://codereview.chromium.org/610083002/) Reason for revert: scoped_ptr nullptr support was reverted. Original issue's description: > Mojo: Convert some scoped_ptr<...>(new ...) to make_scoped_ptr(new ...) in mojo/{embedder,system}. > > R=jamesr@chromium.org > > Committed: https://crrev.com/a60566701028a7344d17826076780eeb84b63052 > Cr-Commit-Position: refs/heads/master@{#297095} TBR=jamesr@chromium.org,viettrungluu@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/3f8f6ea2347da4437dfd56b567c7daddfb9d8940 Cr-Commit-Position: refs/heads/master@{#297108}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M mojo/embedder/simple_platform_shared_buffer_posix.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M mojo/embedder/simple_platform_shared_buffer_win.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M mojo/embedder/test_embedder.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/core_test_base.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/system/raw_channel_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/raw_channel_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
dcheng
Created Revert of Mojo: Convert some scoped_ptr<...>(new ...) to make_scoped_ptr(new ...) in mojo/{embedder,system}.
6 years, 2 months ago (2014-09-27 07:42:19 UTC) #1
viettrungluu
6 years, 2 months ago (2014-09-29 16:50:00 UTC) #2
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/613673004/ by viettrungluu@chromium.org.

The reason for reverting is: scoped_ptr nullptr support was un-reverted..

Powered by Google App Engine
This is Rietveld 408576698