cc:: Remove main_frame_before_draw_enabled from scheduler settings.

cc:: Remove main_frame_before_draw_enabled from scheduler settings.

The flag is set on all platforms and adds uneeded complexity to the
scheduler.

BUG=418368
Committed: https://crrev.com/a772c842fc3107346666ba7884e2d062fa6a5537
Cr-Commit-Position: refs/heads/master@{#297217}

[orglofch, 2014-09-27 01:49:19]

orglofch@chromium.org changed reviewers:
+ brianderson@chromium.org

[orglofch, 2014-09-27 01:51:05]

I removed the main_frame_begin_draw_enabled flag since it simplified my learning
of the state machine (e.g. Removed one of the commit states) and it's enabled on
all platforms.

You don't necessarily need to LGTM this, I though I'd just let you know it
exists.

[brianderson, 2014-09-27 02:30:26]

main_frame_before_draw_enabled is always true now and the flag has outlived it's
usefulness, so we should land this. We can change the behavior manually if it's
really needed.

Can you open a proper bug to reference in the patch.

Thanks for just putting this together.

https://codereview.chromium.org/609003002/diff/1/cc/scheduler/scheduler_state...
File cc/scheduler/scheduler_state_machine.cc (right):

https://codereview.chromium.org/609003002/diff/1/cc/scheduler/scheduler_state...
cc/scheduler/scheduler_state_machine.cc:570:
DCHECK(!active_tree_needs_first_draw_);
DCHECK no longer needed.

[orglofch, 2014-09-27 21:46:42]

https://codereview.chromium.org/609003002/diff/1/cc/scheduler/scheduler_state...
File cc/scheduler/scheduler_state_machine.cc (right):

https://codereview.chromium.org/609003002/diff/1/cc/scheduler/scheduler_state...
cc/scheduler/scheduler_state_machine.cc:570:
DCHECK(!active_tree_needs_first_draw_);
On 2014/09/27 02:30:26, brianderson wrote:
> DCHECK no longer needed.

Done.

[brianderson, 2014-09-29 15:47:22]

lgtm

[orglofch, 2014-09-29 16:52:24]

The CQ bit was checked by orglofch@chromium.org

[commit-bot: I haz the power, 2014-09-29 16:52:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/609003002/20001

[commit-bot: I haz the power, 2014-09-29 17:01:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-29 17:01:22]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[orglofch, 2014-09-29 17:31:45]

orglofch@chromium.org changed reviewers:
+ piman@chromium.org, sievers@chromium.org

[orglofch, 2014-09-29 17:32:12]

+OWNERS 
ptal

[piman, 2014-09-29 18:31:38]

lgtm

[orglofch, 2014-09-29 18:47:37]

The CQ bit was checked by orglofch@chromium.org

[commit-bot: I haz the power, 2014-09-29 18:48:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/609003002/20001

[commit-bot: I haz the power, 2014-09-29 18:50:04]

Committed patchset #2 (id:20001) as 0c5c33f20b76bc5ecc2c5aa9ee9c1db03d243055

[commit-bot: I haz the power, 2014-09-29 18:51:29]

Patchset 2 (id:??) landed as
https://crrev.com/a772c842fc3107346666ba7884e2d062fa6a5537
Cr-Commit-Position: refs/heads/master@{#297217}