Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Issue 608933002: [telemetry] Retry Cloud Storage download on 500 error. (Closed)

Created:
6 years, 2 months ago by dtu
Modified:
6 years, 2 months ago
Reviewers:
tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org, Ken Russell (switch to Gerrit), Jamie Madill
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[telemetry] Retry Cloud Storage download on 500 error. Also remove logic for 401 errors. I don't think this is the correct thing to do, and covers up the real failure. BUG=418225 TEST=None. R=tonyg Committed: https://crrev.com/d42f51125238a34b4d16841207105967c69228c0 Cr-Commit-Position: refs/heads/master@{#297103}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M tools/telemetry/telemetry/util/cloud_storage.py View 4 chunks +12 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
dtu
6 years, 2 months ago (2014-09-26 21:00:53 UTC) #1
tonyg
lgtm
6 years, 2 months ago (2014-09-26 22:06:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/608933002/1
6 years, 2 months ago (2014-09-26 23:06:00 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as cb7591329a351183532b222eac74632f09dcc651
6 years, 2 months ago (2014-09-27 04:23:13 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-09-27 04:24:01 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d42f51125238a34b4d16841207105967c69228c0
Cr-Commit-Position: refs/heads/master@{#297103}

Powered by Google App Engine
This is Rietveld 408576698