content/renderer/webpublicsuffixlist_impl.h - Issue 60893002: Chromium implementation of WebPublicSufixList.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/renderer/webpublicsuffixlist_impl.h

Issue 60893002: Chromium implementation of WebPublicSufixList. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase, rename to blink. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« content/renderer/renderer_webkitplatformsupport_impl.cc ('K') | « content/renderer/renderer_webkitplatformsupport_impl.cc ('k') | content/renderer/webpublicsuffixlist_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CONTENT_RENDERER_WEBPUBLICSUFFIXLIST_IMPL_H_

	6 #define CONTENT_RENDERER_WEBPUBLICSUFFIXLIST_IMPL_H_

	7

	8 #include "base/compiler_specific.h"

	9 #include "third_party/WebKit/public/platform/WebPublicSuffixList.h"

	10

	11 namespace content {

	12

	13 class WebPublicSuffixListImpl : public blink::WebPublicSuffixList {

	14 public:

	15 // WebPublicSuffixList methods:

	16 virtual size_t getPublicSuffixLength(const blink::WebString&) OVERRIDE;
	jamesr 2013/11/15 23:13:47 this is chromium, all parameters get names do not this is chromium, all parameters get names do not use OVERRIDE when implementing an interface in a different repository. this makes it too hard to do two-sided patches. Tom Sepez 2013/11/15 23:22:59 Done. Show quoted text On 2013/11/15 23:13:47, jamesr wrote: > this is chromium, all parameters get names > > do not use OVERRIDE when implementing an interface in a different repository. > this makes it too hard to do two-sided patches. Done.
	17 virtual ~WebPublicSuffixListImpl() OVERRIDE;
	jamesr 2013/11/15 23:13:47 never use OVERRIDE for d'tors - it doesn't make se never use OVERRIDE for d'tors - it doesn't make sense Tom Sepez 2013/11/15 23:22:59 Done. Show quoted text On 2013/11/15 23:13:47, jamesr wrote: > never use OVERRIDE for d'tors - it doesn't make sense Done.
	18 };

	19

	20 } // namespace content

	21

	22 #endif // CONTENT_RENDERER_WEBPUBLICSUFFIXLIST_IMPL_H_

OLD	NEW