Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 608893002: Remove headers for CL, EGL, GLES2, KHR, VG (Closed)

Created:
6 years, 2 months ago by jamesr
Modified:
6 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Visibility:
Public.

Description

Remove headers for CL, EGL, GLES2, KHR, VG In chromium we should never use these headers from mesa. We use the OpenGL ES 2.0 and KHR headers from khronos. Having duplicates in the tree is confusing and a recipe for disaster if the two ever diverge and different versions are used by different libraries, especially since they all use the same include guard so which version is seen by a particular target depends on the include path order. Original review on https://codereview.chromium.org/479683003/ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=292163

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11465 lines) Patch
D include/CL/cl.h View 1 chunk +0 lines, -998 lines 0 comments Download
D include/CL/cl.hpp View 1 chunk +0 lines, -4011 lines 0 comments Download
D include/CL/cl_ext.h View 1 chunk +0 lines, -213 lines 0 comments Download
D include/CL/cl_gl.h View 1 chunk +0 lines, -155 lines 0 comments Download
D include/CL/cl_gl_ext.h View 1 chunk +0 lines, -69 lines 0 comments Download
D include/CL/cl_platform.h View 1 chunk +0 lines, -1198 lines 0 comments Download
D include/CL/opencl.h View 1 chunk +0 lines, -54 lines 0 comments Download
D include/EGL/egl.h View 1 chunk +0 lines, -329 lines 0 comments Download
D include/EGL/eglext.h View 1 chunk +0 lines, -465 lines 0 comments Download
D include/EGL/eglmesaext.h View 1 chunk +0 lines, -160 lines 0 comments Download
D include/EGL/eglplatform.h View 1 chunk +0 lines, -159 lines 0 comments Download
D include/GLES2/gl2.h View 1 chunk +0 lines, -621 lines 0 comments Download
D include/GLES2/gl2ext.h View 1 chunk +0 lines, -1524 lines 0 comments Download
D include/GLES2/gl2platform.h View 1 chunk +0 lines, -30 lines 0 comments Download
D include/KHR/khrplatform.h View 1 chunk +0 lines, -277 lines 0 comments Download
D include/VG/openvg.h View 1 chunk +0 lines, -746 lines 0 comments Download
D include/VG/vgext.h View 1 chunk +0 lines, -233 lines 0 comments Download
D include/VG/vgplatform.h View 1 chunk +0 lines, -92 lines 0 comments Download
D include/VG/vgu.h View 1 chunk +0 lines, -131 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jamesr
6 years, 2 months ago (2014-09-26 19:49:28 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r292163 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698