Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: src/gpu/GrResourceCache2.cpp

Issue 608883003: GrResourceCache2 manages scratch texture. (Closed) Base URL: https://skia.googlesource.com/skia.git@surfimpl
Patch Set: remove todo Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/gpu/GrResourceCache2.h ('k') | src/gpu/GrTexture.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/GrResourceCache2.cpp
diff --git a/src/gpu/GrResourceCache2.cpp b/src/gpu/GrResourceCache2.cpp
index e0ba26ae83516c54d4e87937bef28607f760b64d..85e66a7642ad45ea373eded4ef9c878fcb4ea181 100644
--- a/src/gpu/GrResourceCache2.cpp
+++ b/src/gpu/GrResourceCache2.cpp
@@ -8,7 +8,8 @@
#include "GrResourceCache2.h"
-#include "GrGpuResource.h"
+#include "GrGpuResource.h"
+#include "SkRefCnt.h"
GrResourceCache2::~GrResourceCache2() {
this->releaseAll();
@@ -55,3 +56,32 @@ void GrResourceCache2::releaseAll() {
SkASSERT(!fScratchMap.count());
SkASSERT(!fCount);
}
+
+class GrResourceCache2::AvailableForScratchUse {
+public:
+ AvailableForScratchUse(bool calledDuringFlush) : fFlushing(calledDuringFlush) { }
+
+ bool operator()(const GrGpuResource* resource) const {
+ if (fFlushing) {
+ // If this request is coming during draw buffer flush then no refs are allowed
+ // either by drawing code or for pending io operations.
+ // This will be removed when flush no longer creates resources.
+ return resource->reffedOnlyByCache() && !resource->internalHasPendingIO() &&
+ GrGpuResource::kYes_IsScratch == resource->fIsScratch;
+ } else {
+ // Because duties are currently shared between GrResourceCache and GrResourceCache2, the
+ // current interpretation of this rule is that only GrResourceCache has a ref but that
+ // it has been marked as a scratch resource.
+ return resource->reffedOnlyByCache() &&
+ GrGpuResource::kYes_IsScratch == resource->fIsScratch;
+ }
+ }
+private:
+ bool fFlushing;
+};
+
+GrGpuResource* GrResourceCache2::findAndRefScratchResource(const GrResourceKey& scratchKey,
+ bool calledDuringFlush) {
+ SkASSERT(scratchKey.isScratch());
+ return SkSafeRef(fScratchMap.find(scratchKey, AvailableForScratchUse(calledDuringFlush)));
+}
« no previous file with comments | « src/gpu/GrResourceCache2.h ('k') | src/gpu/GrTexture.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698