src/gpu/GrClipMaskCache.h - Issue 608883003: GrResourceCache2 manages scratch texture.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/GrClipMaskCache.h

Issue 608883003: GrResourceCache2 manages scratch texture. (Closed) Base URL: https://skia.googlesource.com/skia.git@surfimpl

Patch Set: fix and document hack Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/GrClipMaskCache.h

diff --git a/src/gpu/GrClipMaskCache.h b/src/gpu/GrClipMaskCache.h

index 6b484e8af83e15918b63a53704f34ab26de42378..6bc67f4eaa8ea6ea8bbe8fb70118c1e47d8a18d5 100644

--- a/src/gpu/GrClipMaskCache.h

+++ b/src/gpu/GrClipMaskCache.h

@@ -204,7 +204,9 @@ private:

fLastClipGenID = clipGenID;

- fLastMask.set(context, desc);

+ // HACK: set the flags param to a non-zero value to indicate that this request is at

+ // flush time and therefore we require a scratch texture with no pending IO operations.

+ fLastMask.set(context, desc, GrContext::kApprox_ScratchTexMatch, 1);

fLastBound = bound;

}