Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 608863002: Polymer framework files defined in browser resources. (Closed)

Created:
6 years, 2 months ago by dzhioev (left Google)
Modified:
6 years, 2 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Polymer framework files defined in browser resources. Resources added only for Chrome OS build. This is a temporary place for the definitions. When http://crbug.com/418199 is fixed, I will move them to ui/webui/resources. BUG=375191 Committed: https://crrev.com/d298b3b349b00951a3e83ef465c20378eb1e2edf Cr-Commit-Position: refs/heads/master@{#297044}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -0 lines) Patch
M chrome/browser/browser_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
A chrome/browser/polymer_resources.grdp View 1 chunk +50 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dzhioev (left Google)
Hi, please review.
6 years, 2 months ago (2014-09-26 19:41:35 UTC) #2
dzhioev (left Google)
On 2014/09/26 19:41:35, dzhioev wrote: > Hi, please review.
6 years, 2 months ago (2014-09-26 19:54:23 UTC) #4
Lei Zhang
lgtm
6 years, 2 months ago (2014-09-26 20:34:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/608863002/1
6 years, 2 months ago (2014-09-26 20:35:59 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 08be731389a6a23d3824ff4389c369f91cd0a5c4
6 years, 2 months ago (2014-09-26 21:46:57 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 21:47:31 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d298b3b349b00951a3e83ef465c20378eb1e2edf
Cr-Commit-Position: refs/heads/master@{#297044}

Powered by Google App Engine
This is Rietveld 408576698