Source/bindings/tests/idls/core/TestObject.idl - Issue 608853008: Canvas2D Performance: fix the bottleneck of hasInstance in JS binding -- TypeChecking Interface

Side by Side Diff: Source/bindings/tests/idls/core/TestObject.idl

Issue 608853008: Canvas2D Performance: fix the bottleneck of hasInstance in JS binding -- TypeChecking Interface (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: still call toImplWithTypeCheck for undefined arguments + test cases in TestObject.idl Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/bindings/scripts/v8_methods.py ('K') | « Source/bindings/scripts/v8_types.py ('k') | Source/bindings/tests/results/core/V8TestInterface.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2013 Google Inc. All rights reserved.	2 * Copyright (C) 2013 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 534 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
545 [ImplementedInPrivateScript] Node nodeMethodWithVariousArgumentsImplementedI nPrivateScript(Document document, Node node, short value1, double value2, DOMStr ing string);	545 [ImplementedInPrivateScript] Node nodeMethodWithVariousArgumentsImplementedI nPrivateScript(Document document, Node node, short value1, double value2, DOMStr ing string);

546 [ImplementedInPrivateScript] readonly attribute short readonlyShortAttribute ;	546 [ImplementedInPrivateScript] readonly attribute short readonlyShortAttribute ;

547 [ImplementedInPrivateScript] attribute short shortAttribute;	547 [ImplementedInPrivateScript] attribute short shortAttribute;

548 [ImplementedInPrivateScript] attribute DOMString stringAttribute;	548 [ImplementedInPrivateScript] attribute DOMString stringAttribute;

549 [ImplementedInPrivateScript] attribute Node nodeAttribute;	549 [ImplementedInPrivateScript] attribute Node nodeAttribute;

550 [OnlyExposedToPrivateScript] short methodImplementedInCPPForPrivateScriptOnl y(short value1, short value2);	550 [OnlyExposedToPrivateScript] short methodImplementedInCPPForPrivateScriptOnl y(short value1, short value2);

551 [OnlyExposedToPrivateScript] attribute DOMString attributeImplementedInCPPFo rPrivateScriptOnly;	551 [OnlyExposedToPrivateScript] attribute DOMString attributeImplementedInCPPFo rPrivateScriptOnly;

552 [ImplementedInPrivateScript, OnlyExposedToPrivateScript] short methodForPriv ateScriptOnly(short value1, short value2);	552 [ImplementedInPrivateScript, OnlyExposedToPrivateScript] short methodForPriv ateScriptOnly(short value1, short value2);

553 [ImplementedInPrivateScript, OnlyExposedToPrivateScript] attribute DOMString attributeForPrivateScriptOnly;	553 [ImplementedInPrivateScript, OnlyExposedToPrivateScript] attribute DOMString attributeForPrivateScriptOnly;

554 [ImplementedInPrivateScript] attribute TestEnum enumForPrivateScript;	554 [ImplementedInPrivateScript] attribute TestEnum enumForPrivateScript;

	555

	556 [TypeChecking=Interface] void useToImpl4ArgumentsCheckingIfPossibleWithOptio nalArg(Node node1, optional Node node2);
	Jens Widell 2014/10/10 09:26:02 Nit: Move them up to the other [TypeChecking=Inter Nit: Move them up to the other [TypeChecking=Interface] methods? yunchao 2014/10/10 10:36:11 Done. Show quoted text On 2014/10/10 09:26:02, Jens Widell wrote: > Nit: Move them up to the other [TypeChecking=Interface] methods? Done.
	557 [TypeChecking=Interface] void useToImpl4ArgumentsCheckingIfPossibleWithNulla bleArg(Node node1, Node? node2);

	558 [TypeChecking=Interface] void useToImpl4ArgumentsCheckingIfPossibleWithUndef inedArg(Node node1, [Default=Undefined] optional Node node2);

555 };	559 };

OLD	NEW