Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 608853007: [Android] Try to fix menu crash with certain android versions (Closed)

Created:
6 years, 2 months ago by David Trainor- moved to gerrit
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] Try to fix menu crash with certain android versions Certain versions apparently crash when pulling theme string information in TextView. To attempt to fix this (since it's difficult to reproduce), try to revert the string usage to the old version. BUG=416692 NOTRY=true Committed: https://crrev.com/1d1c6977f86b10a64bb05dafe8a0f4406c4cdb8b Cr-Commit-Position: refs/heads/master@{#297859}

Patch Set 1 #

Patch Set 2 : Restored theme #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/android/java/res/values-v17/styles.xml View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
David Trainor- moved to gerrit
ptal thanks!
6 years, 2 months ago (2014-10-01 23:19:06 UTC) #2
David Trainor- moved to gerrit
made this simpler, only removed fontFamily.
6 years, 2 months ago (2014-10-02 17:42:01 UTC) #3
aurimas (slooooooooow)
lgtm
6 years, 2 months ago (2014-10-02 17:45:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/608853007/20001
6 years, 2 months ago (2014-10-02 17:53:07 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 1f6f1b1968c11e4ca452b8cd8bddb65d88454fc6
6 years, 2 months ago (2014-10-02 17:54:33 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 17:55:51 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1d1c6977f86b10a64bb05dafe8a0f4406c4cdb8b
Cr-Commit-Position: refs/heads/master@{#297859}

Powered by Google App Engine
This is Rietveld 408576698