Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 608843002: PPAPI: Add more error testing for postMessageAndAwaitResponse (Closed)

Created:
6 years, 2 months ago by dmichael (off chromium)
Modified:
6 years, 2 months ago
Reviewers:
teravest, bbudge
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

PPAPI: Add more error testing for postMessageAndAwaitResponse Add a test that tries using postMessageAndAwaitResponse in ways that should throw an exception, and makes sure it actually throws. BUG=367896 Committed: https://crrev.com/e5ac6335b792a683c7022f753068751c97374664 Cr-Commit-Position: refs/heads/master@{#297024}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -3 lines) Patch
M ppapi/tests/test_message_handler.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M ppapi/tests/test_message_handler.cc View 1 4 chunks +69 lines, -3 lines 0 comments Download
M ppapi/tests/testing_instance.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M ppapi/tests/testing_instance.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
dmichael (off chromium)
6 years, 2 months ago (2014-09-26 16:53:46 UTC) #2
dmichael (off chromium)
6 years, 2 months ago (2014-09-26 18:38:17 UTC) #4
teravest
https://codereview.chromium.org/608843002/diff/1/ppapi/tests/test_message_handler.cc File ppapi/tests/test_message_handler.cc (right): https://codereview.chromium.org/608843002/diff/1/ppapi/tests/test_message_handler.cc#newcode316 ppapi/tests/test_message_handler.cc:316: ASSERT_EQ("SUCCESS", last_message_); If this assertion fails, will testing_exceptions_ get ...
6 years, 2 months ago (2014-09-26 19:28:50 UTC) #6
dmichael (off chromium)
Took a slightly different approach. Now HandleMessage can tell which test is running by asking ...
6 years, 2 months ago (2014-09-26 20:12:43 UTC) #7
teravest
lgtm
6 years, 2 months ago (2014-09-26 20:14:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/608843002/20001
6 years, 2 months ago (2014-09-26 20:16:35 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as c001780da861b64f221ba70d21f38e9e93d7aea5
6 years, 2 months ago (2014-09-26 20:34:51 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 20:36:02 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e5ac6335b792a683c7022f753068751c97374664
Cr-Commit-Position: refs/heads/master@{#297024}

Powered by Google App Engine
This is Rietveld 408576698