Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 608823002: Update RecordReplaceDrawTest to generate and pass pictures (Closed)

Created:
6 years, 2 months ago by robertphillips
Modified:
6 years, 2 months ago
Reviewers:
egdaniel, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Update RecordReplaceDrawTest to generate and pass pictures This CL splits the unit test changes out of (Fix sub-picture layer rendering bugs - https://codereview.chromium.org/597293002/). For various reasons GrRecordReplaceDraw now needs to take an SkPicture (rather than an SkRecord and a BBH). Committed: https://skia.googlesource.com/skia/+/ee6631ef90fb5a9c80de6eacd37632f11367a088

Patch Set 1 #

Patch Set 2 : move over initialMatrix change too #

Patch Set 3 : Add const #

Total comments: 2

Patch Set 4 : Reordered #include files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -40 lines) Patch
M include/core/SkPicture.h View 1 2 chunks +6 lines, -1 line 0 comments Download
M src/gpu/GrRecordReplaceDraw.h View 1 2 chunks +5 lines, -3 lines 0 comments Download
M src/gpu/GrRecordReplaceDraw.cpp View 1 3 chunks +11 lines, -7 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M tests/RecordReplaceDrawTest.cpp View 1 2 3 5 chunks +46 lines, -27 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
robertphillips
6 years, 2 months ago (2014-09-26 16:47:03 UTC) #2
egdaniel
lgtm + nit https://codereview.chromium.org/608823002/diff/40001/tests/RecordReplaceDrawTest.cpp File tests/RecordReplaceDrawTest.cpp (right): https://codereview.chromium.org/608823002/diff/40001/tests/RecordReplaceDrawTest.cpp#newcode18 tests/RecordReplaceDrawTest.cpp:18: #include "SkPictureRecorder.h" alphabetize?
6 years, 2 months ago (2014-09-26 17:18:11 UTC) #3
bsalomon
rubber stamp lgtm
6 years, 2 months ago (2014-09-26 17:35:42 UTC) #4
robertphillips
https://codereview.chromium.org/608823002/diff/40001/tests/RecordReplaceDrawTest.cpp File tests/RecordReplaceDrawTest.cpp (right): https://codereview.chromium.org/608823002/diff/40001/tests/RecordReplaceDrawTest.cpp#newcode18 tests/RecordReplaceDrawTest.cpp:18: #include "SkPictureRecorder.h" On 2014/09/26 17:18:11, egdaniel wrote: > alphabetize? ...
6 years, 2 months ago (2014-09-29 12:24:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/608823002/60001
6 years, 2 months ago (2014-09-29 12:24:38 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 12:32:53 UTC) #8
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as ee6631ef90fb5a9c80de6eacd37632f11367a088

Powered by Google App Engine
This is Rietveld 408576698