Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 608813003: Revert of Clear GCM data when the user clears cookies and other site data (Closed)

Created:
6 years, 2 months ago by jianli
Modified:
6 years, 2 months ago
Reviewers:
Bernhard Bauer, fgorski
CC:
chromium-reviews, markusheintz_, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Clear GCM data when the user clears cookies and other site data (patchset #6 id:100001 of https://codereview.chromium.org/562423002/) Reason for revert: We're not longer doing this. Original issue's description: > Clear GCM data when the user clears cookies and other site data > > This is needed for the work to drop GCM sign-in enforcement. Since > we no longer wipe out the GCM data when the user signs out, we need > to give user a chance to clear the data if he or she wants. > > BUG=384041 > TEST=Manual test by selecting "Cookies and other site and plugin data" > > Committed: https://crrev.com/6967652cefa1e306d21e70d4a12dcc0ac572c28b > Cr-Commit-Position: refs/heads/master@{#294754} TBR=bauerb@chromium.org,fgorski@chromium.org NOTREECHECKS=true NOTRY=true BUG=384041 Committed: https://crrev.com/11ba40b0dc3dd641702e8c50229c4facb5096107 Cr-Commit-Position: refs/heads/master@{#296989}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -70 lines) Patch
M chrome/browser/browsing_data/browsing_data_remover.h View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover.cc View 3 chunks +0 lines, -12 lines 0 comments Download
M chrome/browser/extensions/api/browsing_data/browsing_data_test.cc View 1 chunk +9 lines, -11 lines 0 comments Download
M chrome/browser/services/gcm/gcm_profile_service.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M components/gcm_driver/fake_gcm_driver.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/gcm_driver/fake_gcm_driver.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M components/gcm_driver/gcm_driver.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/gcm_driver/gcm_driver_android.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/gcm_driver/gcm_driver_android.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M components/gcm_driver/gcm_driver_desktop.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/gcm_driver/gcm_driver_desktop.cc View 2 chunks +7 lines, -11 lines 0 comments Download
M components/gcm_driver/gcm_driver_desktop_unittest.cc View 3 chunks +1 line, -14 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jianli
Created Revert of Clear GCM data when the user clears cookies and other site data
6 years, 2 months ago (2014-09-26 18:37:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/608813003/1
6 years, 2 months ago (2014-09-26 18:37:57 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 825b51425c6e6c5d9033ec5043a496a3e1defbe7
6 years, 2 months ago (2014-09-26 18:38:58 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 18:39:42 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/11ba40b0dc3dd641702e8c50229c4facb5096107
Cr-Commit-Position: refs/heads/master@{#296989}

Powered by Google App Engine
This is Rietveld 408576698