Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1359)

Unified Diff: src/test/run-all-unittests.cc

Issue 608773002: initialize v8 early in unittests (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/test/run-all-unittests.cc
diff --git a/src/test/run-all-unittests.cc b/src/test/run-all-unittests.cc
index 8c361ddc3683eeb4af4f432b1454f540de41fbf9..c42f2b01031a9b3da4548840d786e0982057b8c9 100644
--- a/src/test/run-all-unittests.cc
+++ b/src/test/run-all-unittests.cc
@@ -5,6 +5,7 @@
#include "include/libplatform/libplatform.h"
#include "include/v8.h"
#include "src/base/compiler-specific.h"
+#include "src/v8.h"
#include "testing/gmock/include/gmock/gmock.h"
namespace {
@@ -38,6 +39,9 @@ class DefaultPlatformEnvironment FINAL : public ::testing::Environment {
int main(int argc, char** argv) {
+ // This forces some thread local key initialization that may be need to print
Jakob Kummerow 2014/09/26 14:14:35 nit: s/need/needed/
+ // out the names of the unit tests.
+ i::V8::Initialize();
testing::InitGoogleMock(&argc, argv);
testing::AddGlobalTestEnvironment(new DefaultPlatformEnvironment);
v8::V8::SetFlagsFromCommandLine(&argc, argv, true);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698