Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 608693006: [Easy Unlock] When hardlocking, show a different icon on user (Closed)

Created:
6 years, 2 months ago by tbarzic
Modified:
6 years, 2 months ago
Reviewers:
xiyuan, oshima
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Easy Unlock] When hardlocking, show a different icon on user The previous behaviour was to hide it. Also, update some icon resources. Note: this does not yet work well with easy signin. BUG=406234 Committed: https://crrev.com/98a07838b754c13f7269319e2bb35ab5edfcbc61 Cr-Commit-Position: refs/heads/master@{#297284}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : fix bad merge #

Patch Set 8 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+307 lines, -55 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/lock/screen_locker.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.cc View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/signin/easy_unlock_screenlock_state_handler.h View 3 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/signin/easy_unlock_screenlock_state_handler.cc View 8 chunks +80 lines, -10 lines 0 comments Download
M chrome/browser/signin/easy_unlock_screenlock_state_handler_unittest.cc View 6 chunks +85 lines, -15 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service.h View 4 chunks +17 lines, -0 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service.cc View 1 2 5 chunks +23 lines, -0 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_regular.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_regular.cc View 2 chunks +20 lines, -0 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_signin_chromeos.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_signin_chromeos.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h View 1 2 3 4 5 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 2 3 4 5 3 chunks +39 lines, -30 lines 0 comments Download
A ui/resources/default_100_percent/common/easy_unlock_hardlocked.png View 1 2 Binary file 0 comments Download
M ui/resources/default_100_percent/common/easy_unlock_locked.png View Binary file 0 comments Download
M ui/resources/default_100_percent/common/easy_unlock_spinner.png View Binary file 0 comments Download
A ui/resources/default_200_percent/common/easy_unlock_hardlocked.png View 1 2 Binary file 0 comments Download
M ui/resources/default_200_percent/common/easy_unlock_locked.png View Binary file 0 comments Download
M ui/resources/default_200_percent/common/easy_unlock_spinner.png View Binary file 0 comments Download
M ui/resources/ui_resources.grd View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
tbarzic
xiyuan: the main reviewer oshima: owner for ui/resources
6 years, 2 months ago (2014-09-26 23:58:48 UTC) #2
xiyuan
LGTM Do we want to change UserSessionManager::UpdateEasyUnlockKeys to remove all keys when hard lock is ...
6 years, 2 months ago (2014-09-27 17:42:11 UTC) #3
oshima
ui/resources lgtm
6 years, 2 months ago (2014-09-27 17:56:55 UTC) #4
tbarzic
On 2014/09/27 17:42:11, xiyuan wrote: > LGTM > > Do we want to change UserSessionManager::UpdateEasyUnlockKeys ...
6 years, 2 months ago (2014-09-29 18:32:19 UTC) #5
tbarzic
On 2014/09/29 18:32:19, tbarzic wrote: > On 2014/09/27 17:42:11, xiyuan wrote: > > LGTM > ...
6 years, 2 months ago (2014-09-29 21:01:12 UTC) #6
xiyuan
SLGTM
6 years, 2 months ago (2014-09-29 21:02:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/608693006/140001
6 years, 2 months ago (2014-09-29 21:07:31 UTC) #9
commit-bot: I haz the power
Committed patchset #8 (id:140001) as 7e48b4f82aef2b04ab9a11b25d33d96b11b3cb41
6 years, 2 months ago (2014-09-29 22:21:31 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 22:22:39 UTC) #11
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/98a07838b754c13f7269319e2bb35ab5edfcbc61
Cr-Commit-Position: refs/heads/master@{#297284}

Powered by Google App Engine
This is Rietveld 408576698