[Easy Unlock] When hardlocking, show a different icon on user
The previous behaviour was to hide it.
Also, update some icon resources.
Note: this does not yet work well with easy signin.
BUG=406234
Committed: https://crrev.com/98a07838b754c13f7269319e2bb35ab5edfcbc61
Cr-Commit-Position: refs/heads/master@{#297284}
xiyuan: the main reviewer oshima: owner for ui/resources
6 years, 2 months ago
(2014-09-26 23:58:48 UTC)
#2
xiyuan: the main reviewer
oshima: owner for ui/resources
xiyuan
LGTM Do we want to change UserSessionManager::UpdateEasyUnlockKeys to remove all keys when hard lock is ...
6 years, 2 months ago
(2014-09-27 17:42:11 UTC)
#3
LGTM
Do we want to change UserSessionManager::UpdateEasyUnlockKeys to remove all keys
when hard lock is on?
oshima
ui/resources lgtm
6 years, 2 months ago
(2014-09-27 17:56:55 UTC)
#4
ui/resources lgtm
tbarzic
On 2014/09/27 17:42:11, xiyuan wrote: > LGTM > > Do we want to change UserSessionManager::UpdateEasyUnlockKeys ...
6 years, 2 months ago
(2014-09-29 18:32:19 UTC)
#5
On 2014/09/27 17:42:11, xiyuan wrote:
> LGTM
>
> Do we want to change UserSessionManager::UpdateEasyUnlockKeys to remove all
keys
> when hard lock is on?
No, I don't think we do. I think the hardlock should be disabled when the user
logs in (I had forgotten to upload the part that does this)
tbarzic
On 2014/09/29 18:32:19, tbarzic wrote: > On 2014/09/27 17:42:11, xiyuan wrote: > > LGTM > ...
6 years, 2 months ago
(2014-09-29 21:01:12 UTC)
#6
On 2014/09/29 18:32:19, tbarzic wrote:
> On 2014/09/27 17:42:11, xiyuan wrote:
> > LGTM
> >
> > Do we want to change UserSessionManager::UpdateEasyUnlockKeys to remove all
> keys
> > when hard lock is on?
>
> No, I don't think we do. I think the hardlock should be disabled when the user
> logs in (I had forgotten to upload the part that does this)
xiyuan, can you have another look at
chrome/browser/chromeos/login/session/user_session_manager.cc (I did not have
this in the reviewed patchset)
xiyuan
SLGTM
6 years, 2 months ago
(2014-09-29 21:02:49 UTC)
#7
SLGTM
tbarzic
The CQ bit was checked by tbarzic@chromium.org
6 years, 2 months ago
(2014-09-29 21:04:02 UTC)
#8
Issue 608693006: [Easy Unlock] When hardlocking, show a different icon on user
(Closed)
Created 6 years, 2 months ago by tbarzic
Modified 6 years, 2 months ago
Reviewers: xiyuan, oshima
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 0