Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 608683003: Add placeholder translations for Athena (Closed)

Created:
6 years, 2 months ago by pkotwicz
Modified:
6 years, 2 months ago
Reviewers:
tfarina, tony
CC:
chromium-reviews, oshima
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add placeholder translations for Athena BUG=416206 TEST=None R=tfarina,tony TBR=oshima Committed: https://crrev.com/7d56ae7a00c0952fa695842aa87414c16d2d46e3 Cr-Commit-Position: refs/heads/master@{#297213}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, --51 lines) Patch
M athena/strings/athena_strings.grd View 1 chunk +53 lines, -1 line 1 comment Download
A + athena/strings/translations/athena_strings_am.xtb View 0 chunks +-1 lines, --1 lines 1 comment Download
A + athena/strings/translations/athena_strings_ar.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_bg.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_bn.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_ca.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_cs.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_da.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_de.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_el.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_en-GB.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_es.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_es-419.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_et.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_fa.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_fi.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_fil.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_fr.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_gu.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_hi.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_hr.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_hu.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_id.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_it.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_iw.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_ja.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_kn.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_ko.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_lt.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_lv.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_ml.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_mr.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_ms.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_nl.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_no.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_pl.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_pt-BR.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_pt-PT.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_ro.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_ru.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_sk.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_sl.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_sr.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_sv.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_sw.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_ta.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_te.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_th.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_tr.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_uk.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_vi.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_zh-CN.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/strings/translations/athena_strings_zh-TW.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
pkotwicz
tfarina@ PTAL I did not add a BUILD.gn file because athena does not use BUILD.gn ...
6 years, 2 months ago (2014-09-26 15:35:07 UTC) #1
tfarina
lgtm https://codereview.chromium.org/608683003/diff/1/athena/strings/athena_strings.grd File athena/strings/athena_strings.grd (right): https://codereview.chromium.org/608683003/diff/1/athena/strings/athena_strings.grd#newcode106 athena/strings/athena_strings.grd:106: <file path="translations/athena_strings_am.xtb" lang="am" /> looks correct and matches ...
6 years, 2 months ago (2014-09-26 19:33:02 UTC) #2
pkotwicz
tony@ can you please take a look? I am not sure if I should have ...
6 years, 2 months ago (2014-09-26 21:06:50 UTC) #4
tony
You don't need to add launchpad_translations. LGTM.
6 years, 2 months ago (2014-09-26 21:09:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/608683003/1
6 years, 2 months ago (2014-09-29 17:52:48 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 61721034265e52b93f69b791bc2579d2db8bb37f
6 years, 2 months ago (2014-09-29 18:28:33 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 18:29:55 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7d56ae7a00c0952fa695842aa87414c16d2d46e3
Cr-Commit-Position: refs/heads/master@{#297213}

Powered by Google App Engine
This is Rietveld 408576698