Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 608653002: Add support for using DOM Distiller in incognito. (Closed)

Created:
6 years, 2 months ago by nyquist
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add support for using DOM Distiller in incognito. Currently the DOM Distiller does not work in incognito, since the source for the chrome-distiller:// scheme has not been registered. This CL moves the functionality for registering the scheme to a generic place and it is now used by both ProfileImpl and by OffTheRecordProfile during profile creation. It also makes both the normal profile and the incognito profile use the same instance of the DomDistillerService. BUG=380036 Committed: https://crrev.com/6e3ab0a5c3ca6fcb76a736107e08dbbbf1e2637a Cr-Commit-Position: refs/heads/master@{#296974}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -25 lines) Patch
M chrome/browser/dom_distiller/dom_distiller_service_factory.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A chrome/browser/dom_distiller/profile_utils.h View 1 chunk +14 lines, -0 lines 0 comments Download
A chrome/browser/dom_distiller/profile_utils.cc View 1 chunk +29 lines, -0 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 3 chunks +1 line, -22 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
nyquist
cjhopman: PTAL
6 years, 2 months ago (2014-09-25 21:05:32 UTC) #2
nyquist
erg: PTAL chrome/browser/profiles
6 years, 2 months ago (2014-09-25 22:30:17 UTC) #4
cjhopman
lgtm
6 years, 2 months ago (2014-09-25 22:35:48 UTC) #5
Elliot Glaysher
lgtm
6 years, 2 months ago (2014-09-26 17:27:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/608653002/1
6 years, 2 months ago (2014-09-26 17:29:27 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as b2c2dca570dc64f39716e03678e4f43c9da64bfc
6 years, 2 months ago (2014-09-26 17:54:35 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 17:55:25 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e3ab0a5c3ca6fcb76a736107e08dbbbf1e2637a
Cr-Commit-Position: refs/heads/master@{#296974}

Powered by Google App Engine
This is Rietveld 408576698