Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 60863002: Mojo: Support camel cased types in generator (Closed)

Created:
7 years, 1 month ago by DaveMoore
Modified:
7 years, 1 month ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: Support camel cased types in generator BUG=315193 TEST=None R=darin@chromium.org, darin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233279

Patch Set 1 #

Patch Set 2 : Additional fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -45 lines) Patch
M mojo/public/bindings/generators/cpp_templates/struct_serialization.h-template View 1 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/public/bindings/generators/mojom_cpp_generator.py View 1 21 chunks +44 lines, -40 lines 0 comments Download
M mojo/public/bindings/sample/sample_service.mojom View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
DaveMoore
With this change we support camel cased struct types. We don't do any auto conversion ...
7 years, 1 month ago (2013-11-06 15:36:39 UTC) #1
darin (slow to review)
LGTM
7 years, 1 month ago (2013-11-06 15:44:33 UTC) #2
DaveMoore
7 years, 1 month ago (2013-11-06 16:26:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r233279 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698