Issue 608613003: monacl: build_newlib -> build_pnacl_newlib.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 608613003: monacl: build_newlib -> build_pnacl_newlib. (Closed)

Created:
6 years, 2 months ago by viettrungluu

Modified:
6 years, 2 months ago

Reviewers:
Nick Bray (chromium)

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

monacl: build_newlib -> build_pnacl_newlib. R=ncbray@chromium.org Committed: https://crrev.com/6b2ce16b4fc752306829a12c16f9742484784bf1 Cr-Commit-Position: refs/heads/master@{#297223}

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -8 lines)			Patch
M	mojo/mojo_nacl.gyp	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	mojo/nacl/generator/libmojo.cc.tmpl	View	1 chunk	+1 line, -1 line	0 comments	Download
M	testing/gtest_nacl.gyp	View	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/608613003/1

6 years, 2 months ago (2014-09-29 19:06:02 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (id:1) as 7e97be707f5cf2317da9122dde10a0fe8cd123ba

6 years, 2 months ago (2014-09-29 19:10:45 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-09-29 19:12:05 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/6b2ce16b4fc752306829a12c16f9742484784bf1
Cr-Commit-Position: refs/heads/master@{#297223}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages